Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Correctly identify comma separated dtype strings #10624

Merged
merged 1 commit into from Feb 18, 2018

Conversation

Projects
None yet
2 participants
@charris
Copy link
Member

commented Feb 18, 2018

Backport of #10623.

When parsing dtype strings, we should only consider them to
be comma seperated if there are commas not present in a
pair of square brackets.

Whilst we had a check for this already in the code there was
an off by 1 bug where we failed to consider the first character
of the string. This would lead to an infinite recursion when
trying to parse strings of the form [i8,f8].

Fixes: #10440

BUG: Correctly identify comma seperated dtype strings
When parsing dtype strings, we should only consider them to
be comma seperated if there are commas not present in a
pair of square brackets.

Whilst we had a check for this already in the code there was
an off by 1 bug where we failed to consider the first character
of the string. This would lead to an infinite recursion when
trying to parse strings of the form `[i8,f8]`.

Fixes: #10440

@charris charris added this to the 1.14.1 release milestone Feb 18, 2018

@charris charris merged commit 23e3fb5 into numpy:maintenance/1.14.x Feb 18, 2018

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
lgtm analysis: Python No alert changes
Details

@charris charris deleted the charris:backport-10623 branch Feb 18, 2018

@eric-wieser eric-wieser changed the title BUG: Correctly identify comma seperated dtype strings BUG: Correctly identify comma separated dtype strings Feb 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.