Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: dragon4 fractional output mode adds too many trailing zeros #10725

Merged
merged 1 commit into from Mar 11, 2018

Conversation

Projects
None yet
2 participants
@charris
Copy link
Member

commented Mar 11, 2018

Backport of #10716.

For this I just copied the dragon4.c and test_scalarprint.py files from master, as there seemed to be a few other fixups for spelling and such that came in at some point.

Fixes #10713

There was a miscalculation in the number of trailing zeros to add when using format_float_positional with the option fractional=False, which specifies that the precision parameter refers to the total number of digits, not the number of fractional digits.

In that case we should be adding enough zeros so that precision equals the total number of digits; instead it was adding zeros so that precision equaled the number of fractional digits.

@charris charris added this to the 1.14.2 release milestone Mar 11, 2018

@charris charris merged commit 02c1bc5 into numpy:maintenance/1.14.x Mar 11, 2018

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
lgtm analysis: Python No alert changes
Details

@charris charris deleted the charris:backport-10716 branch Mar 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.