Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add riscv support #10761

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@kraj
Copy link

commented Mar 17, 2018

Signed-off-by: Khem Raj raj.khem@gmail.com

npy_cpu: Add riscv support
Signed-off-by: Khem Raj <raj.khem@gmail.com>

@charris charris changed the title npy_cpu: Add riscv support ENH: Add riscv support Mar 17, 2018

@njsmith

This comment has been minimized.

Copy link
Member

commented Mar 17, 2018

Does this ... do anything? It seems like it's just defining a new constant that nothing ever looks at...

@kraj

This comment has been minimized.

Copy link
Author

commented Mar 17, 2018

right. this is first step in fixing the build though

@pv

This comment has been minimized.

Copy link
Member

commented Mar 17, 2018

It removes the "Unknown CPU" error message, so probably not useful to merge as is, without confirming that the build actually works (including floating point etc. stuff that the CPU flag controls).
I.e., the PR should "Add riscv support".

@kraj

This comment has been minimized.

Copy link
Author

commented Mar 17, 2018

Fair enough. I only have QEMU up here right now. I will try to run the unit tests on it and see how far I get.

@charris

This comment has been minimized.

Copy link
Member

commented Apr 6, 2018

@kraj Any progress on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.