MAINT: Work around non-deterministic Python readdir order in distutils #11163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
reviewed
May 26, 2018
numpy/distutils/misc_util.py
Outdated
| @@ -882,7 +882,7 @@ def _wildcard_get_subpackage(self, subpackage_name, | |||
| caller_level = 1): | |||
| l = subpackage_name.split('.') | |||
| subpackage_path = njoin([self.local_path]+l) | |||
| dirs = [_m for _m in glob.glob(subpackage_path) if os.path.isdir(_m)] | |||
| dirs = [_m for _m in sorted(glob.glob(subpackage_path)) if os.path.isdir(_m)] | |||
There was a problem hiding this comment.
Sort of inconsistent with what you do above. Either you should sort the outer list comprehension here, or you should always sort glob, even if it's unused.
My preference would be a sorted_glob helper function, with a comment explaining why it's necessary.
so that the python-scikit-learn openSUSE package that uses config.add_extension(name, "path/to/*.cpp", ...) builds in a reproducible way in spite of indeterministic filesystem readdir order and http://bugs.python.org/issue30461 See https://reproducible-builds.org/ for why this is good.
charris
changed the title
|
@eric-wieser Look good to you? |
eric-wieser
approved these changes
May 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Sort input file list
so that the python-scikit-learn openSUSE package
that uses config.add_extension(name, "path/to/*.cpp", ...)
builds in a reproducible way
in spite of indeterministic filesystem readdir order
and http://bugs.python.org/issue30461
See https://reproducible-builds.org/ for why this is good.