Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: add sanity-checks to be run at import time #11174

Merged
merged 1 commit into from May 27, 2018

Conversation

Projects
None yet
2 participants
@charris
Copy link
Member

commented May 27, 2018

Backport of #11169.

This checks for potential BLAS issues, which are useful to catch early.

As suggested by @charris at #11168. This may be a bit overkill, so not sure if we want this, but on the other hand this additional import-time check probably does not cost much. The additional advantage is that import-time failures will force the downstream to seriously consider addressing the issue :)

MAINT: add sanity-checks to be run at import time
This checks for potential BLAS issues, which are useful to catch early.

@charris charris added this to the 1.14.4 release milestone May 27, 2018

@charris charris merged commit 5b3b867 into numpy:maintenance/1.14.x May 27, 2018

6 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
lgtm analysis: C/C++ No alert changes
Details
lgtm analysis: JavaScript No alert changes
Details
lgtm analysis: Python No alert changes
Details

@charris charris deleted the charris:backport-11169 branch May 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.