Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: optimizing compilers can reorder call to npy_get_floatstatus #11198

Merged
merged 1 commit into from May 30, 2018

Conversation

Projects
None yet
1 participant
@charris
Copy link
Member

commented May 30, 2018

Backport of #11036.

We should find a more generic and explicit way to prevent optimizing
compilers from reordering the call to npy_get_floatstatus.

To reproduce the problem, clang or gcc-8.1 are required. Confirmed that
this fixes the problem using clang-6.0

BUG: optimizing compilers can reorder call to npy_get_floatstatus
We should find a more generic and explicit way to prevent optimizing
compilers from reordering the call to npy_get_floatstatus.

To reproduce the problem, clang or gcc-8.1 are required. Confirmed that
this fixes the problem using clang-6.0

@charris charris added this to the 1.14.4 release milestone May 30, 2018

@charris charris merged commit ab34a33 into numpy:maintenance/1.14.x May 30, 2018

6 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
lgtm analysis: C/C++ No alert changes
Details
lgtm analysis: JavaScript No alert changes
Details
lgtm analysis: Python No alert changes
Details

@charris charris deleted the charris:backport-11036 branch May 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.