Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix regression in intersect1d. #11777

Merged
merged 1 commit into from Aug 18, 2018

Conversation

Projects
None yet
1 participant
@charris
Copy link
Member

commented Aug 18, 2018

Backport of #11774.

The function was failing for non-ndarray objects that defined
that defined array, in particular xarray.DataArray. Fix
by calling asanyarray on the inputs, which was done implicitly
before.

Closes #11772.

BUG: Fix regression in intersect1d.
The function was failing for non-ndarray objects that defined
that defined __array__, in particular `xarray.DataArray`. Fix
by calling asanyarray on the inputs, which was done implicitly
before.

Closes #11772.

@charris charris added this to the 1.15.1 release milestone Aug 18, 2018

@charris charris merged commit a5454cf into numpy:maintenance/1.15.x Aug 18, 2018

6 checks passed

LGTM analysis: C/C++ No alert changes
Details
LGTM analysis: JavaScript No alert changes
Details
LGTM analysis: Python No alert changes
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@charris charris deleted the charris:fix-intersect1d branch Aug 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.