Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Prepare master for 1.17.0 development. #12506

Merged
merged 1 commit into from Dec 8, 2018

Conversation

@charris
Copy link
Member

commented Dec 7, 2018

MAINT: Prepare master for 1.17.0 development.

  • Create 1.17.0-notes
  • Update index.rst for new notes
  • Update pavement.py
  • Update setup.py
  • Remove Python 2.7 and 3.4 CI testing.
  • Add # cython: language_level=3 to *.pxd, *.pyx files.

Note that this removes support for both Python2.7 and Python3.4 in
setup.py.

@charris charris force-pushed the charris:prepare-for-1.17-development branch from b08d579 to 78fc3ea Dec 7, 2018

setup.py Outdated Show resolved Hide resolved
setup.py Show resolved Hide resolved

@charris charris force-pushed the charris:prepare-for-1.17-development branch from 78fc3ea to ddff5b0 Dec 8, 2018

@rgommers
Copy link
Member

left a comment

Mostly LGTM. You are just missing an entry in doc/source/release.rst

@charris charris force-pushed the charris:prepare-for-1.17-development branch 2 times, most recently from 54a89d5 to c94b587 Dec 8, 2018

@rgommers

This comment has been minimized.

Copy link
Member

commented Dec 8, 2018

You still need to remove the Python 2.7 entry from the Shippable build matrix.

MAINT: Prepare master for 1.17.0 development.
- Create 1.17.0-notes
- Update index.rst for new notes
- Update pavement.py
- Update setup.py
- Remove Python 2.7 and 3.4 from CI testing.
- Add `# cython: language_level=3` to `*.pxd`, `*.pyx` files.

Note that this removes support for both Python2.7 and Python3.4 in
setup.py.

@charris charris force-pushed the charris:prepare-for-1.17-development branch from c94b587 to badf290 Dec 8, 2018

@charris

This comment has been minimized.

Copy link
Member Author

commented Dec 8, 2018

Updated.

@rgommers rgommers merged commit f2dbb70 into numpy:master Dec 8, 2018

9 checks passed

LGTM analysis: C/C++ No code changes detected
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python 13 new alerts and 12 fixed alerts
Details
Shippable Run 1806 status is SUCCESS.
Details
azure-pipeline numpy.numpy Build #20181208.8 succeeded
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 8ee86d5...badf290
Details
codecov/project 84.94% remains the same compared to 8ee86d5
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rgommers

This comment has been minimized.

Copy link
Member

commented Dec 8, 2018

Merged, thanks Chuck

@charris charris deleted the charris:prepare-for-1.17-development branch Dec 17, 2018

ruiztulio added a commit to vauxoo-dev/docker-odoo-image that referenced this pull request Jul 11, 2019

[FIX] Change pandas an numpy versions.
The latest numpy version is not compatible with p2, the support was removed in 1.17.0: numpy/numpy#12506
Also removed the pandas package from full requirements so it use the one from addons-vauxoo: https://github.com/Vauxoo/addons-vauxoo/blob/8.0/requirements.txt\#L1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.