BLD: catch link error. #15406
Merged
BLD: catch link error. #15406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When system_info.py is trying to find cblas as libblas, there can be a different library called libblas that doesn't contain the referenced function cblas_ddot. This raises a distutils.errors.LinkError, which is currently not caught. This patch fixes numpy#15389. The system_info in master was reworked for 1.17, and doesn't have this issue.
|
Thanks @rsmith-nl . I went ahead and merged, it can't hurt. Whether or not there is another release of 1.16, we will see. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When system_info.py is trying to find cblas as libblas, there can be a
different library called libblas that doesn't contain the referenced
function cblas_ddot. This raises a distutils.errors.LinkError, which
is currently not caught.
This patch fixes #15389.
The system_info in master was reworked for 1.17, and doesn't have this
issue.