Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Proposal to expire three deprecated functions in numpy.lib.npyio #19615

Merged
merged 4 commits into from Aug 6, 2021

Conversation

rossbar
Copy link
Contributor

@rossbar rossbar commented Aug 5, 2021

There are three functions in the npyio module which are all in the main namespace that are suitable for removal according to the criteria laid out in NEP23:

  • np.loads, deprecated in v1.15
  • np.ndfromtxt and np.mafromtxt, both deprecated in v1.17.

This PR proposes to remove them outright, but happy to hear thoughts on the appropriate course of action.

seberg
seberg approved these changes Aug 5, 2021
Copy link
Member

@seberg seberg left a comment

Weird that the tests actually only use genfromtext (I guess to avoid the warning...). In any case we seem to have more tests with usemask=True so looks good to me, unless anyone wants to nitpick the release notes :).

@rossbar
Copy link
Contributor Author

@rossbar rossbar commented Aug 5, 2021

unless anyone wants to nitpick the release notes

Suggestions welcome - I'm happy to expand/reorganize them!

@charris
Copy link
Member

@charris charris commented Aug 6, 2021

so looks good to me, unless anyone wants to nitpick the release notes

I'll edit them all into a list when the release notes are generated.

@charris charris merged commit 261a769 into numpy:main Aug 6, 2021
39 checks passed
@charris
Copy link
Member

@charris charris commented Aug 6, 2021

Thanks Ross.

@rossbar rossbar deleted the rm-deprecated-npyio-fns branch Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants