BUG,DEP: Non-default UFunc signature/dtype usage should be deprecated #19632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, this was an straight typeerror that went mostly unnoticed for 1.21.0 and 1.21.1. However, that was never the intention, it should have been a normal DeprecationWarning to allow transition where necessary.
|
But see the PEP8 complaints... |
Ah, it is a one character too long line, happy to ignore or change :). |
seberg
added
09 - Backport-Candidate
|
Thanks Sebastian. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, this was an straight typeerror that went mostly unnoticed
for 1.21.0 and 1.21.1. However, that was never the intention, it should
have been a normal DeprecationWarning to allow transition where necessary.
Closes gh-19625