Skip to content

Conversation

@DWesl
Copy link
Contributor

@DWesl DWesl commented Oct 28, 2021

Attempt to close #20221 by rebasing NumPy dlls to avoid fork() failures.

@DWesl
Copy link
Contributor Author

DWesl commented Oct 28, 2021

Is there a way to tell the CI that these three files primarily affect the "Test on Cygwin / cygwin_build_test" run so it doesn't need to bother running most of the tests?

@mattip
Copy link
Member

mattip commented Oct 29, 2021

Rather than run the whole test suite, you can add specific tests via the -t argument to runtests.py, or add pytest-specific arguments after -- so something like runtest.py ... -- <pytest stuff here>

dash -c "/usr/bin/python3.8 runtests.py -n -vv"

@DWesl
Copy link
Contributor Author

DWesl commented Oct 29, 2021

Rather than run the whole test suite, you can add specific tests via the -t argument to runtests.py, or add pytest-specific arguments after -- so something like runtest.py ... -- <pytest stuff here>

dash -c "/usr/bin/python3.8 runtests.py -n -vv"

I was thinking more along the lines of not running the Windows, Linux, or Mac tests on a PR that only touches the Cygwin test driver and three helper scripts only used on Cygwin, since the changes should only affect the Cygwin tests and a few of the linters.

If I get a good description of which files impact which parts of the test suite, I'll try to put that in a format other CI jobs can use.

@charris charris merged commit 9b0b40b into numpy:main Oct 29, 2021
@charris
Copy link
Member

charris commented Oct 29, 2021

Thanks @DWesl .

@DWesl DWesl deleted the run-rebase-on-cygwin-ci branch December 24, 2021 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI: Cygwin failure tracking issue

3 participants