Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Fix a Arrayterator typing test failure #20302

Merged
merged 1 commit into from
Nov 4, 2021

Conversation

BvB93
Copy link
Member

@BvB93 BvB93 commented Nov 4, 2021

Closes #20301

Remove a stray quotation mark.

@BvB93 BvB93 added this to the 1.21.4 release milestone Nov 4, 2021
@BvB93 BvB93 added the 08 - Backport Used to tag backport PRs label Nov 4, 2021
@BvB93
Copy link
Member Author

BvB93 commented Nov 4, 2021

Ah, seems this is a partial backport of #19242, which originally fixed the issue when bumping to mypy 0.902.

@charris
Copy link
Member

charris commented Nov 4, 2021

So it might be a side effect of my upgrading to mypy 0.310?

@BvB93
Copy link
Member Author

BvB93 commented Nov 4, 2021 via email

@charris charris merged commit 5d3c424 into numpy:maintenance/1.21.x Nov 4, 2021
@charris
Copy link
Member

charris commented Nov 4, 2021

Thanks Bas.

@BvB93 BvB93 linked an issue Nov 4, 2021 that may be closed by this pull request
@BvB93 BvB93 deleted the arrayterator2 branch November 4, 2021 23:06
@charris charris changed the title TST: Fix a Arrayterator typing test failure TST: Fix a Arrayterator typing test failure Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typing test error in maintenance/1.21.x
2 participants