Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Fix METH_NOARGS function signatures #20430

Merged
merged 1 commit into from Nov 22, 2021

Conversation

charris
Copy link
Member

@charris charris commented Nov 21, 2021

Backport of #20368.

This is a continuation of @joemarshall's work #19058.

I think there should be a bunch of more issues around METH_NOARGS usage that would be nice to fix up as well.
@seberg in #19058 (comment)

This fixes all of the incorrect METH_NOARGS signatures that I managed to track down.
We need this for pyodide/pyodide#1677.

The METH_NOARGS calling convention is required to take a second PyObject* which will always be NULL.

This is a continuation of numpy#19058
@charris charris added this to the 1.22.0 release milestone Nov 21, 2021
@charris charris merged commit 265118d into numpy:maintenance/1.22.x Nov 22, 2021
35 of 36 checks passed
@charris charris deleted the backport-20368 branch Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants