Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT,TST: Refactor F2PY testsuite #20517

Merged
merged 2 commits into from Dec 8, 2021
Merged

Conversation

HaoZeke
Copy link
Member

@HaoZeke HaoZeke commented Dec 4, 2021

Essentially this makes better usage of the util.py helpers. It will also make testing more transparent and easier to extend since now one can directly write nice Fortran formatted tests instead of massaging lines in python.

Additionally, one point which came up was the speed. AFAIK the time taken to run the tests has decreased, and not increased.

# On main
python runtests.py -m full -s f2py
# 670 passed, 6 skipped in 66.84s (0:01:06)
# On this branch
python runtests.py -m full -s f2py
# 670 passed, 6 skipped in 60.85s (0:01:00)

Similar behavior in terms of time taken was observed in the skeletal test repository.

Other changes:

  • Almost no dependencies left on numpy.testing other than IS_PYPY

Copy link
Contributor

@pearu pearu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Co-authored-by: Melissa Weber Mendonça <melissawm@gmail.com>
@melissawm
Copy link
Member

This looks good - thanks @HaoZeke

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants