-
-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REL: Prepare for NumPy 1.21.6 release. #21323
REL: Prepare for NumPy 1.21.6 release. #21323
Conversation
charris
commented
Apr 11, 2022
•
edited
Loading
edited
- Create 1.21.6-changelog.rst.
- Update 1.21.6-notes.rst.
- Fix circleci doc builds.
- Change azure-pipelines Mac vmImage to macOS-1015.
Sorry, I hadn't realize this was coming now. Can you hold off until tomorrow? |
Sure. This came up at the end of scipy/oldest-supported-numpy#45. Do you intend to add something? |
Yeah, there is one small fix I have been meaning to do for a while and it should be quick. |
Oh, just realized that this is 1.21.x not 1.22.x. Still happy to backport, though, but maybe not as pressing. (and there is a tiny chance of backcompat issues, so only if a 1.21.7 wouldn't be too much hassle.) |
I'd rather avoid any potential problems. I wouldn't do this at all if the |
A 1.22 fix would be welcome, though. Things there have quieted a lot since 1.22.3, so probably only one more release. |
aa2f794
to
a69d3af
Compare
- Create 1.21.6-changelog.rst. - Update 1.21.6-notes.rst. - Fix circleci doc builds. - Change azure-pipelines Mac vmImage to macOS-1015. - Use Python 3.8 for typing tests on Mac.
a69d3af
to
24a8ec0
Compare
if this release will be able to build from source on Windows?
As I read test-related scripts the test process uses the system python which does not use latest setuptools. |
@Czaki NumPy often does not build with latest setuptools, which are changing regularly these days. We are pinned to older versions and will change the build to use meson at some point on account of the instability. Windows builds are difficult in any case and are best avoided when possible. |
@BvB93 I'm trying to do a 1.21.6 release, but am now getting typing errors for no reason I can see. Could you take a look at the error messages and see if there is anything that can be easily fixed? Something has changed. EDIT: The tests run without problems on my machine, the errors seem to be Mac specific, and possibly due to the azure-pipeline environment. |
@charris Thanks for your response. Now I check and I would love to avoid numpy builds but I also would love to deliver pypy wheels. |
@Czaki you can get PyPy wheels for windows from the weekly builds
If this doesn't work or is not what you want, please open a separate issue. |
Same here on my Mac; locally the tests pass without issue. It's not clear to me what could be causing the issue here, though based on the reproducibility issue presumably something related to azure? |
Sounds like it, they have broken things before, it is really annoying. Guess I'll put this in and see if the wheel builds pass. If not, is there an easy way to disable the tests? |
We could always add an xfail for Mac with these specific tests. |
The wheel builds passed. Not sure what the differences are, need to take a look at that someday. |
Sure, we can always add an xfail for Mac if worst comes to worst.
On 12 Apr 2022, at 01:24, Charles Harris ***@***.***> wrote:
presumably something related to azure?
Sounds like it, they have broken things before, it is really annoying. Guess I'll put this in and see if the wheel builds pass. If not, is there an easy way to disable the tests?
—
Reply to this email directly, view it on GitHub<#21323 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AKK4FQ6SUIGQJUNUPUWSYJLVESYCVANCNFSM5TDVTGZA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|