Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST, MAINT: Replace most setup with setup_method (also teardown) #22489

Merged
merged 6 commits into from Oct 28, 2022

Conversation

charris
Copy link
Member

@charris charris commented Oct 27, 2022

Backport of #22487.

In some cases, the replacement is clearly not what is intended,
in those (where setup was called explicitly), I mostly renamed
setup to _setup.
The test_ccompile_opt is a bit confusing, so left it right now
(this will probably fail)


Also changed the docs a little bit. (Draft, just because I expect one failure still.)

Closes gh-22486

Not actually sure that setup_module() is what was wanted here, but
it works?
Mention a bit more about actual pytest fixtures.
In some cases, the replacement is clearly not what is intended,
in those (where setup was called explicitly), I mostly renamed
`setup` to `_setup`.
The `test_ccompile_opt` is a bit confusing, so left it right now
(this will probably fail)
Not new things, but in touched lines...
@charris charris added this to the 1.23.5 release milestone Oct 27, 2022
@charris charris changed the title TST,MAINT: Replace most setup with setup_method (also teardown) TST, MAINT: Replace most setup with setup_method (also teardown) Oct 28, 2022
@charris charris merged commit 3b22591 into numpy:maintenance/1.23.x Oct 28, 2022
39 of 40 checks passed
@charris charris deleted the backport-22487 branch October 28, 2022 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants