-
-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG, SIMD: Fix invalid value encountered in several ufuncs #22834
Conversation
Providing non-signaling comparison intrinsics that guarantee no FP invalid exception in case of qNaN sounds great but it cost unacceptable extra intrinsics on ppc64le(VSX) and x86(SSE). Therefore, an integer definition #NPY_SIMD_CMPSIGNAL has been provided instead to differenate between SIMD extensions that support only supports signaling comparison.
@seiko2plus I suspect there is another backport needed to fix the invalid value in power error. Any idea what that is? |
My editor trimmed whitespace of this line: numpy/numpy/core/tests/test_umath.py Line 1091 in 28329b2
For somehow during rebases, you bring the power test cases instead of ignoring trimming the white space.
either backport #18535 and #22737 or just removes the power test case. |
Fixes missing backports that can wait until 1.24.x.
Thanks @seiko2plus. I deleted the test. |
Backport of #22771.
closes #22461, #22772, #22797
for more clarification check the linked issues above