Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG, SIMD: Fix invalid value encountered in several ufuncs #22834

Merged
merged 8 commits into from Dec 20, 2022

Conversation

charris
Copy link
Member

@charris charris commented Dec 19, 2022

Backport of #22771.

closes #22461, #22772, #22797

  • Fix invalid value encountered in rint/trunc/ceil/floor on armhf/neon
  • Fix invalid value encountered in rint/trunc/ceil/floor on x86/SSE2
  • Fix invalid value encountered in expm1 when SVML/AVX512 enabled
  • Fix invalid value encountered in cos/sin on aarch64 & ppc64le

for more clarification check the linked issues above

  Providing non-signaling comparison intrinsics that guarantee
  no FP invalid exception in case of qNaN sounds great but it
  cost unacceptable extra intrinsics on  ppc64le(VSX) and x86(SSE).

  Therefore, an integer definition #NPY_SIMD_CMPSIGNAL has been
  provided instead to differenate between SIMD extensions
  that support only supports signaling comparison.
@charris charris added 00 - Bug 08 - Backport Used to tag backport PRs component: SIMD Issues in SIMD (fast instruction sets) code or machinery labels Dec 19, 2022
@charris charris added this to the 1.24.1 release milestone Dec 19, 2022
@charris
Copy link
Member Author

charris commented Dec 19, 2022

@seiko2plus I suspect there is another backport needed to fix the invalid value in power error. Any idea what that is?

@seiko2plus
Copy link
Member

Any idea what that is?

My editor trimmed whitespace of this line:

#Complex powers with positive real part will not generate a warning

For somehow during rebases, you bring the power test cases instead of ignoring trimming the white space.

I suspect there is another backport needed to fix the invalid value in power error.

either backport #18535 and #22737 or just removes the power test case.

Fixes missing backports that can wait until 1.24.x.
@charris
Copy link
Member Author

charris commented Dec 20, 2022

Thanks @seiko2plus. I deleted the test.

@charris charris merged commit d337ba9 into numpy:maintenance/1.24.x Dec 20, 2022
49 of 50 checks passed
@charris charris deleted the backport-22771 branch December 20, 2022 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
00 - Bug 08 - Backport Used to tag backport PRs component: SIMD Issues in SIMD (fast instruction sets) code or machinery
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants