Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: restore npymath implementations needed for freebsd #22883

merged 1 commit into from Dec 25, 2022


Copy link

@charris charris commented Dec 25, 2022

Backport of #22882.

Closes #22850

FreeBSD is missing the long double variants of some complex geometric functions that should be mandatory in C11. Restore them from the removed code (taken from diffing to v1.23.5)

I tested this on a 1GB FreeBSD qemu image, and discovered there is a test that should be skipped on such a limited machine. With the skip the tests ran to completion, but there were a number of failures related to floating-point error reporting. It may be worth taking a look if we get FreeBSD CI going.

@charris charris added 03 - Maintenance 08 - Backport Used to tag backport PRs labels Dec 25, 2022
@charris charris added this to the 1.24.1 release milestone Dec 25, 2022
Copy link
Member Author

charris commented Dec 25, 2022

@mattip Only the first commit seemed relevant here, the second was all meson related.

@charris charris merged commit 0f3484a into numpy:maintenance/1.24.x Dec 25, 2022
50 checks passed
@charris charris deleted the backport-22882 branch December 25, 2022 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
03 - Maintenance 08 - Backport Used to tag backport PRs
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants