MAINT: explicitly check for NaNs in allclose(). Closes #1905. #239

Closed
wants to merge 2 commits into
from

Projects

None yet

2 participants

@rgommers
Member

Also clean up the logic behind handling infs.

The removed seterr call becomes unnecessary when explicitly checking for NaNs.
It was introduced only recently in c4c0e98.

@rgommers rgommers MAINT: explicitly check for NaNs in allclose(). Closes #1905.
Also clean up the logic behind handling infs.

The removed seterr call becomes unnecessary when explicitly checking for NaNs.
It was introduced only recently in c4c0e98.
830b554
@charris
Member
charris commented Mar 25, 2012

Looks good. I think the docstring should mention that infs of the same sign in the same place are treated as equal.

@rgommers
Member

done

@charris
Member
charris commented Mar 25, 2012

Pushed in 3503c5f..aea76b8.

@charris charris closed this Mar 25, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment