New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Disallow shadowed modulenames #25205
Conversation
3213160
to
659751b
Compare
|
This seems to have a prerequisite backport. Will wait until more go in and rebase. |
|
@HaoZeke Any ideas as to what is needed for this to work? It seems related to using the meson backend, but the |
Yeah the problem is that test doesn't need to have |
|
I think it might have been in |
In general #25210 is better, runs the same test for filename on |
Backport of #25181 and #25185.
This is a better version of #25114.
Closes #22819. Closes #25182.
Enforces the following:
-mis passed with a.pyfin a-ccall, the name is ignored and taken from the.pyffile (the only logical option)-crun will only produce onepythonmodule, so there can only be one.pyffile-mis passed without-cand.pyffiles are present (new, BUG:f2pygenerates incorrect wrapper files when passed-mand a.pyf#25182)For the last point
-m blahis internally replaced with-m modnamefrom the.pyffile, so no additional (incorrect) wrappers are produced.There already is a note in the documentation, but this is a much better solution (and also paves the way for #25111). The documentation could probably use an update, and since this is technically a user facing change it might need a release note.