BUG: Avoid regression in np.insert for axis!=0 or None #2697

Merged
merged 1 commit into from Nov 12, 2012

Conversation

Projects
None yet
2 participants
Member

seberg commented Oct 23, 2012

This avoids a regression with insert failing where it worked before when inserting a full array with a scalar and axis!=0. See also Issue #378 and #452. There is a larger explanation in #378.

I really think that introducing this regression should probably be avoided. A more extensive (compatible) change for development branch in #452. This is a minimal change to make np.insert in 1.7. compatible with 1.6.

BUG: Avoid regression in np.insert for axis!=0 or None
This avoids a regression with insert failing where it worked
before when inserting a full array with a scalar and axis!=0.
See also Issue #378 and #452.
Owner

njsmith commented Nov 12, 2012

I haven't followed all the details here but it seems like this fixes a regression and I don't want it to get forgotten for 1.7, so I'll go ahead and merge...

njsmith added a commit that referenced this pull request Nov 12, 2012

Merge pull request #2697 from seberg/reginsert
BUG: Avoid regression in np.insert for axis!=0 or None

@njsmith njsmith merged commit 26d1565 into numpy:maintenance/1.7.x Nov 12, 2012

1 check passed

default The Travis build passed
Details

@seberg seberg deleted the seberg:reginsert branch Mar 6, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment