BUG: fix download link in setup.py (which is shown on PyPi). #2707

Merged
merged 1 commit into from Nov 14, 2012

Projects

None yet

4 participants

@rgommers
Member
rgommers commented Nov 5, 2012

Closes Trac ticket 2243.

@certik: should be backported to 1.7.x

I'll upload a new PKGINFO to PyPi for 1.6.2 when this is merged.

@charris charris commented on the diff Nov 9, 2012
LICENSE = 'BSD'
CLASSIFIERS = filter(None, CLASSIFIERS.split('\n'))
AUTHOR = "Travis E. Oliphant, et.al."
AUTHOR_EMAIL = "oliphant@enthought.com"
PLATFORMS = ["Windows", "Linux", "Solaris", "Mac OS-X", "Unix"]
-MAJOR = 1
-MINOR = 8
+MAJOR = 1
+MINOR = 8
@charris
charris Nov 9, 2012 Member

This needs to be changed to 7 for the backport, right?

@rgommers
rgommers Nov 9, 2012 Member

Indeed. I can fix that and backport this myself; Ondrej is busy IIRC.

@charris
charris Nov 9, 2012 Member

You might as well commit it then. I checked the URL and it looks good to me. I assume PyPi can figure out the versions from there?

@rgommers
rgommers Nov 9, 2012 Member

Guess so, but I'll check when I upload a fix for 1.6.2 to PyPi.

@rgommers
rgommers Nov 9, 2012 Member

Eh, sorry, replied too fast. Your question doesn't parse. PyPi doesn't figure out versions. Do you mean pip?

@charris
charris Nov 9, 2012 Member

On Fri, Nov 9, 2012 at 9:56 AM, Ralf Gommers notifications@github.comwrote:

In setup.py:

LICENSE = 'BSD'
CLASSIFIERS = filter(None, CLASSIFIERS.split('\n'))
AUTHOR = "Travis E. Oliphant, et.al."
AUTHOR_EMAIL = "oliphant@enthought.com"
PLATFORMS = ["Windows", "Linux", "Solaris", "Mac OS-X", "Unix"]
-MAJOR = 1
-MINOR = 8
+MAJOR = 1
+MINOR = 8

Eh, sorry, replied too fast. Your question doesn't parse. PyPi doesn't
figure out versions. Do you mean pip?

Actually, I don't know what I'm talking about ;) I just used your PR
comment.

@certik
Contributor
certik commented Nov 14, 2012

@rgommers, can you do this? I don't want to make a mistake while backporting this.

@rgommers rgommers merged commit 067b5f8 into numpy:master Nov 14, 2012

1 check passed

default The Travis build passed
Details
@rgommers
Member

OK, merging this. Will backport too.

@rgommers
Member

Backported in 98ca13d.

@stefanv
Contributor
stefanv commented Nov 14, 2012

BTW, that should also probably be "et al."
On Nov 14, 2012 12:32 PM, "Ralf Gommers" notifications@github.com wrote:

Backported in 98ca13d 98ca13d.


Reply to this email directly or view it on GitHubhttps://github.com/numpy/numpy/pull/2707#issuecomment-10383224.

@rgommers
Member

"that" = ?

@stefanv
Contributor
stefanv commented Nov 14, 2012

Sorry, "Travis Oliphant, et. al" -> "Travis Oliphant et al." in the AUTHOR field.

@rgommers
Member

Yeah, it's been et al for a while. New PR?

@stefanv
Contributor
stefanv commented Nov 14, 2012

My most glorious PR yet: #2744 :-)

@certik
Contributor
certik commented Nov 14, 2012

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment