2to3: Apply basestring fixer. #3237

Merged
merged 1 commit into from Apr 14, 2013

Projects

None yet

1 participant

@charris
Member
charris commented Apr 13, 2013

The basestring class is not defined in Python 3 and the fixer replaces
it with str. In order to have a common code base we define basestring in
numpy/compat/py3k.py to be str when the Python version is >= 3,
otherwise basestring and import it where needed. That works for most
cases, but there are a few files where the version dependent define
needs to be in the file.

Closes #3042.

@charris charris 2to3: Apply basestring fixer.
The basestring class is not defined in Python 3 and the fixer replaces
it with str. In order to have a common code base we define basestring in
numpy/compat/py3k.py to be str when the Python version is >= 3,
otherwise basestring and import it where needed.  That works for most
cases, but there are a few files where the version dependent define
needs to be in the file.

Closes #3042.
68338ee
@charris
Member
charris commented Apr 14, 2013

Still looks good in the morning. Merging.

@charris charris merged commit 01ed88a into numpy:master Apr 14, 2013

1 check passed

default The Travis build passed
Details
@charris charris deleted the charris:2to3-apply-basestring branch Apr 14, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment