BUG: Fix ticket #1588/gh issue #398, refcount error in clip #405

Merged
merged 2 commits into from Aug 31, 2012

Conversation

Projects
None yet
3 participants
Contributor

certik commented Aug 31, 2012

Updated PR #400 with a test and rebased against master.

Mark, can you review the test please? I checked that it segfaults before your patch and passes after your patch.

/cc @mwiebe

mwiebe and others added some commits Aug 31, 2012

BUG: Fix ticket #1588/gh issue #398, refcount error in clip
This patch enforces a strict dichotomy for the variables 'indescr'
and 'newdescr', so they are either NULL, or they own a reference.
Following the consequences of this allowed the reference error
to be tracked down.
BUG: Add a test for Ticket #1588
The bug was fixed by the previous patch.
Member

mwiebe commented Aug 31, 2012

Looks good to me.

@certik certik referenced this pull request Aug 31, 2012

Closed

Ticket 1588 #398

This pull request passes (merged 1039880 into 8c75aa0).

Contributor

certik commented Aug 31, 2012

Thanks Mark for the review. Merging.

certik added a commit that referenced this pull request Aug 31, 2012

Merge pull request #405 from certik/pr400_fix
BUG: Fix ticket #1588/gh issue #398, refcount error in clip

@certik certik merged commit e60c70d into numpy:master Aug 31, 2012

1 check passed

default The Travis build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment