FIX: loosen numerical tolerance in test_pareto() #430

Merged
merged 1 commit into from Sep 11, 2012

Conversation

Projects
None yet
2 participants
@njsmith
Member

njsmith commented Sep 7, 2012

[This is a tighter version of #425 and I think supersedes it]

The problem was that in 32bit Ubuntu 12.04, one gets the following:

/home/njs/numpy/.tox/py27/local/lib/python2.7/site-packages/numpy/random/tests/test_random.py(363)test_pareto()
-> np.testing.assert_array_almost_equal(actual, desired, decimal=15)
(Pdb) actual[1, 0]
52828779.702948704
(Pdb) desired[1, 0]
52828779.702948518

and the test was comparing the numbers to 1e-14, which obviously
failed.

Fixes #424.

FIX: loosen numerical tolerance in test_pareto()
The problem was that in 32bit Ubuntu 12.04, one gets the following:

>
/home/njs/numpy/.tox/py27/local/lib/python2.7/site-packages/numpy/random/tests/test_random.py(363)test_pareto()
-> np.testing.assert_array_almost_equal(actual, desired, decimal=15)
(Pdb) actual[1, 0]
52828779.702948704
(Pdb) desired[1, 0]
52828779.702948518

and the test was comparing the numbers to 1e-14, which obviously
failed.

Fixes #424.
@njsmith

This comment has been minimized.

Show comment Hide comment
@njsmith

njsmith Sep 11, 2012

Member

No-one seems to object, so merging...

Member

njsmith commented Sep 11, 2012

No-one seems to object, so merging...

njsmith added a commit that referenced this pull request Sep 11, 2012

Merge pull request #430 from njsmith/test_pareto-fix
FIX: loosen numerical tolerance in test_pareto()

@njsmith njsmith merged commit 6315567 into numpy:master Sep 11, 2012

1 check failed

default The Travis build failed
Details
@certik

This comment has been minimized.

Show comment Hide comment
@certik

certik Sep 11, 2012

Contributor

This is +1.

Contributor

certik commented Sep 11, 2012

This is +1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment