Add usage help and write output in binary mode #4794

Closed
wants to merge 1 commit into
from

Projects

None yet

4 participants

@techtonik
Contributor

Writing output in binary mode allows to avoid line feed conversion on Windows

@techtonik techtonik Add usage help and write output in binary mode
Writing output in binary mode allows to avoid line feed conversion on Windows
1bd7cd9
@juliantaylor
Collaborator

I don't think we are still doing another 1.8 release and numeric has been removed in master, so this patch will likely never be released

@techtonik
Contributor

Is there any user level doc how to manually transform old Numeric code to new NumPy?

@techtonik
Contributor

Otherwise people like me will still have to download 1.8.x to convert it.

@charris
Member
charris commented Jun 9, 2014

Maybe we could put the conversion script in the tools directory. It would need a better name and perhaps some cleanup. The tools directory is not be included in the install, but a least the script would be available in master.

@techtonik
Contributor

Conversion script would be awesome.

@charris
Member
charris commented Jun 9, 2014

@techtonic PR's welcome ;)

@techtonik
Contributor

I know neither Numeric nor NumPy rules (just trying to get old robot simulator going). Is there any manual conversion guide?

@charris
Member
charris commented Jun 9, 2014

Ah, that makes it tough ;) I thought you could start with the 1.8 alter_code1.py, then maybe take a look at
alter_code2.py, which looks to be a non-finished improvement. I have no idea how well either works. You can also ask on the mailing list, there are bound to be some folks who have dealt with that problem before and some may have written tools for the job. And if you are doing a conversion yourself, that experience should help point up problems to fix.

@techtonik
Contributor

I am not sure I will be able to dedicate much time to this, but to make initiative sustainable and distributed among people, here is what can be done:

Strategy: incremental, example driven, always beta (commit early and often)

  1. Find place for the tool in new source code repository (single script)
  2. This place should include subpath for test data with manually done conversions (ask people to add there)
  3. Merge all the code from alter_* scripts into one, comment old code, describe plan (review conversion code, uncomment and refactor) and current status (so that anybody can pickup and continue)
  4. Update http://www.numpy.org/old_array_packages.html with link to new tool location and this strategy
  5. First feature - tool should be able to run its tests
@jaimefrio
Member

Regardless of whether those other scripts are ever written, I think this can be closed.
Give me a shout if you would like to reopen it, @techtonik.

@jaimefrio jaimefrio closed this Sep 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment