Temporarily disable __numpy_ufunc__ #7147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two identical copies of test_dot_override in test_multiarray.py. This seems surplus to requirements.
Given that we accidentally released 1.11b2 with `__numpy_ufunc__` still enabled, we should probably just disable it in master for now. When ready to re-enable, grep for NUMPY_UFUNC_DISABLED. Or just revert this commit.
| @@ -4615,24 +4633,6 @@ def test_dot_scalar_and_matrix_of_objects(self): | |||
| assert_equal(np.dot(arr, 3), desired) | |||
| assert_equal(np.dot(3, arr), desired) | |||
|
|
|||
| def test_dot_override(self): | |||
There was a problem hiding this comment.
Out of curiosity, where is the duplicate of this?
There was a problem hiding this comment.
charris
added a commit
that referenced
this pull request
Jan 31, 2016
Temporarily disable __numpy_ufunc__
|
Thanks Nathaniel. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that we accidentally released 1.11b2 with
__numpy_ufunc__stillenabled, we should probably just disable it in master for now.
When ready to re-enable, grep for NUMPY_UFUNC_DISABLED. Or just revert
bac094c.
Note that this pull request also contains an additional commit that
removes a duplicate test -- that doesn't need reverting.
Needs backport to 1.11 branch.