New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Make system_info output reproducible #9652

Merged
merged 1 commit into from Sep 5, 2017

Conversation

Projects
None yet
3 participants
@lamby
Contributor

lamby commented Sep 5, 2017

Whilst working on the Reproducible Builds effort [0], we noticed
that python-numpy generates output that is not reproducible. This
affects "downstream" packages such as numexpr.

This occurs as it encodes the absolute pathname into the generated file.

[0] https://reproducible-builds.org/

Signed-off-by: Chris Lamb chris@chris-lamb.co.uk

@njsmith

This comment has been minimized.

Show comment
Hide comment
@njsmith

njsmith Sep 5, 2017

Member

Seems reasonable to me.

Maybe we should add the string "numpy" to the file somewhere, so if people see "generated by misc_util.py" then they have some clue which project to look for this in?

Member

njsmith commented Sep 5, 2017

Seems reasonable to me.

Maybe we should add the string "numpy" to the file somewhere, so if people see "generated by misc_util.py" then they have some clue which project to look for this in?

Make system_info output reproducible
Whilst working on the Reproducible Builds effort [0], we noticed
that python-numpy generates output that is not reproducible. This
affects "downstream" packages such as numexpr.

This occurs as it encodes the absolute pathname into the generated file.

 [0] https://reproducible-builds.org/

Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk>
@lamby

This comment has been minimized.

Show comment
Hide comment
@lamby

lamby Sep 5, 2017

Contributor

@njsmith wrote:

Maybe we should add the string "numpy" to the file somewhere

Good idea. Pushed an updated commit.

Contributor

lamby commented Sep 5, 2017

@njsmith wrote:

Maybe we should add the string "numpy" to the file somewhere

Good idea. Pushed an updated commit.

@charris charris changed the title from Make system_info output reproducible to BUG: Make system_info output reproducible Sep 5, 2017

@charris

This comment has been minimized.

Show comment
Hide comment
@charris

charris Sep 5, 2017

Member

Note changed PR title. We like to have certain prefixes on the commit message, see the list at doc/source/dev/gitwash/development_workflow.rst.

Member

charris commented Sep 5, 2017

Note changed PR title. We like to have certain prefixes on the commit message, see the list at doc/source/dev/gitwash/development_workflow.rst.

@lamby

This comment has been minimized.

Show comment
Hide comment
@lamby

lamby Sep 5, 2017

Contributor

Thanks!

Contributor

lamby commented Sep 5, 2017

Thanks!

@charris charris merged commit cb4d802 into numpy:master Sep 5, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

theodoregoetz added a commit to theodoregoetz/numpy that referenced this pull request Oct 23, 2017

Make system_info output reproducible (#9652)
Whilst working on the Reproducible Builds effort [0], we noticed
that python-numpy generates output that is not reproducible. This
affects "downstream" packages such as numexpr.

This occurs as it encodes the absolute pathname into the generated file.

 [0] https://reproducible-builds.org/

Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment