New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Make f2py generated file not contain the (local) date. #9780

Merged
merged 2 commits into from Sep 27, 2017

Conversation

Projects
None yet
3 participants
@bmwiedemann
Contributor

bmwiedemann commented Sep 27, 2017

While working on the reproducible builds effort, I found that when building the python-scipy package for openSUSE Linux, there were slight differences between each build that can be avoided with this patch to
Allow to override build date
and use gmtime in order to be independent of timezone
in order to make builds reproducible.
See https://reproducible-builds.org/ for why this is good
and https://reproducible-builds.org/specs/source-date-epoch/
for the definition of this variable.

@bashtage

This comment has been minimized.

Show comment
Hide comment
@bashtage

bashtage Sep 27, 2017

Contributor

You need to change your PR title.

Contributor

bashtage commented Sep 27, 2017

You need to change your PR title.

@charris

This comment has been minimized.

Show comment
Hide comment
@charris

charris Sep 27, 2017

Member

The lines with "Revision" and "Date" were for subversion. I'd just remove all of them, including also the time and the outdated link.

Member

charris commented Sep 27, 2017

The lines with "Revision" and "Date" were for subversion. I'd just remove all of them, including also the time and the outdated link.

@charris

This comment has been minimized.

Show comment
Hide comment
@charris

charris Sep 27, 2017

Member

And you need to completely redo your commit message. See doc/source/dev/gitwash/development_workflow.rst.

Member

charris commented Sep 27, 2017

And you need to completely redo your commit message. See doc/source/dev/gitwash/development_workflow.rst.

@bmwiedemann bmwiedemann changed the title from While working on the reproducible builds effort, I found that when building the python-scipy package for openSUSE Linux, there were slight differences between each build that can be avoided with this patch to to Allow to override build date Sep 27, 2017

Show outdated Hide outdated numpy/f2py/rules.py Outdated
Show outdated Hide outdated numpy/f2py/rules.py Outdated
Show outdated Hide outdated numpy/f2py/rules.py Outdated

bmwiedemann added some commits Sep 27, 2017

ENH: Allow to override build date
and use gmtime in order to be independent of timezone
in order to make builds reproducible.
See https://reproducible-builds.org/ for why this is good
and https://reproducible-builds.org/specs/source-date-epoch/
for the definition of this variable.
MAINT: remove outdated entries in f2py
because svn is not used anymore
@charris

This comment has been minimized.

Show comment
Hide comment
@charris

charris Sep 27, 2017

Member

I note that f2py is now released together with NumPy, so its own version number no longer tracks changes. If reproducibility requires a known version something more might be required.

Member

charris commented Sep 27, 2017

I note that f2py is now released together with NumPy, so its own version number no longer tracks changes. If reproducibility requires a known version something more might be required.

@charris charris changed the title from Allow to override build date to MAINT: Make f2py generated file not contain the (local) date. Sep 27, 2017

@charris charris merged commit 1e45fd9 into numpy:master Sep 27, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@charris

This comment has been minimized.

Show comment
Hide comment
@charris

charris Sep 27, 2017

Member

Merged, thanks @bmwiedemann.

There may be more work needed here, but I don't know the precise aims that you have in the reproducibile build project.

Member

charris commented Sep 27, 2017

Merged, thanks @bmwiedemann.

There may be more work needed here, but I don't know the precise aims that you have in the reproducibile build project.

@bmwiedemann

This comment has been minimized.

Show comment
Hide comment
@bmwiedemann

bmwiedemann Sep 28, 2017

Contributor

For now, my goal is for all 11800 openSUSE source packages to be able to build twice and produce identical binary packages (which was not the case for python-scipy before this patch, because of the timestamps).
Version numbers usually do not matter there, because they do not vary between builds.

Contributor

bmwiedemann commented Sep 28, 2017

For now, my goal is for all 11800 openSUSE source packages to be able to build twice and produce identical binary packages (which was not the case for python-scipy before this patch, because of the timestamps).
Version numbers usually do not matter there, because they do not vary between builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment