Skip to content

Conversation

@yajo
Copy link
Contributor

@yajo yajo commented Apr 19, 2022

Can't run $(nix-build shell.nix) because it's a directory.

Can't run $(nix-build shell.nix)/entrypoint because $PRJ_ROOT env var is missing.

Gotta do what these docs now say, to be able to successfully use devshell on CI systems.

Can't run `$(nix-build shell.nix)` because it's a directory.

Can't run `$(nix-build shell.nix)/entrypoint` because `$PRJ_ROOT` env var is missing.

Gotta do what these docs now say, to be able to successfully use devshell on CI systems.
@zimbatm zimbatm merged commit 5a53bbf into numtide:master Apr 19, 2022
@zimbatm
Copy link
Member

zimbatm commented Apr 19, 2022

thanks!

Actually, if you run nix-shell --run "make" it will be essentially the same.

Another way is PRJ_ROOT=$PWD $(nix-build shell.nix)/entrypoint make

@yajo yajo deleted the docs-fix-ci branch April 19, 2022 17:59
@yajo
Copy link
Contributor Author

yajo commented Apr 19, 2022

I've made some experiments and it behaved differently. TBH I've done like 50 different attempts and at this point I'm not sure what the problem was, though.

@zimbatm
Copy link
Member

zimbatm commented Apr 19, 2022

I need to re-think PRJ_ROOT a bit TBH. It's would be better if it was defaulting to the git top-level or something.

@blaggacao
Copy link
Contributor

@yajo nice to see you around here 😄

@blaggacao
Copy link
Contributor

I need to re-think PRJ_ROOT a bit TBH. It's would be better if it was defaulting to the git top-level or something.

Let me know I want to make this same interface part of divnix/std. 🙏

tennox pushed a commit to tennox/devshell that referenced this pull request May 17, 2022
Can't run `$(nix-build shell.nix)` because it's a directory.

Can't run `$(nix-build shell.nix)/entrypoint` because `$PRJ_ROOT` env var is missing.

Gotta do what these docs now say, to be able to successfully use devshell on CI systems.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants