Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.3.4 #60

Open
wants to merge 23 commits into
base: master
from
Open

v1.3.4 #60

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
af8c4cb
update version number
amiantos May 30, 2019
2d33fe3
add basic deezer support
amiantos May 30, 2019
1a7b6bb
add basic amazon support
amiantos May 30, 2019
d77746c
remove references to old pusher instance
amiantos May 31, 2019
80787b9
add ipad version and start to clean up iPad views
amiantos Jun 13, 2019
8ce1251
convert artist view to UISplitView
amiantos Jun 13, 2019
254b665
attempt to fix weird tab bar shadow under splitview master controller
amiantos Jun 13, 2019
0bfc979
adjust sizing on some settings views for ipad support
amiantos Jun 13, 2019
7374c02
all settings views look okay on iPad now
amiantos Jun 13, 2019
321e732
get sort view to resize properly on iPad
amiantos Jun 13, 2019
ffa5758
fix default artist detail view message
amiantos Jun 13, 2019
a8a9b9e
disable landscape mode on iPhone but leave on iPad
amiantos Jun 13, 2019
4ea0c49
fill in iPad icons
amiantos Jun 13, 2019
9b623cd
commit build number
amiantos Jun 13, 2019
6b2c0a4
keep release detail view controller size consistent on iPad
amiantos Jun 14, 2019
7408c27
expand sort view sizing to more comfortable volume
amiantos Jun 14, 2019
7fa7d88
add selection color to artists view controller
amiantos Jun 14, 2019
a882fe3
make spacing around explanatory text more consistent and more iPhone-…
amiantos Jun 14, 2019
f1849f3
restyle UIButtons
amiantos Jun 14, 2019
01193cf
reorganize storyboard
amiantos Jun 14, 2019
d52307f
fallback to mailto link if mail app isn't present
amiantos Jun 14, 2019
a89d65e
add patronage, blog, and github links to More view
amiantos Jun 14, 2019
ce88a39
adjust some spacing and wording on more screen
amiantos Jun 14, 2019
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

restyle UIButtons

  • Loading branch information...
amiantos committed Jun 14, 2019
commit f1849f38327ec8fed805cebb980ff8694c988a2d
@@ -184,7 +184,6 @@
441CC0A7215C516E009F4114 /* Classes */ = {
isa = PBXGroup;
children = (
441CC0A9215C522E009F4114 /* Interface */,
B42866071DA5FC53000E5FA6 /* User.swift */,
B440D9D61DB2D19300477938 /* ArtistItem.swift */,
B4283ABC1D8658AD00467CE6 /* ReleaseItem.swift */,
@@ -204,18 +203,11 @@
B4CCFCC01DB425D900D2277B /* More */,
447FED38217811810084530E /* Modals */,
B4D5960822B23D46006B4439 /* ArtistsSplitViewController.swift */,
);
path = Views;
sourceTree = "<group>";
};
441CC0A9215C522E009F4114 /* Interface */ = {
isa = PBXGroup;
children = (
B4CCFCC61DB4353E00D2277B /* NumuUIButton.swift */,
B471648C1F5FA24600D4E03E /* NumuTextField.swift */,
B40E35911DB1D88C004BA8C7 /* NumuTabBarController.swift */,
);
path = Interface;
path = Views;
sourceTree = "<group>";
};
443EBB91217054800071A11D /* Release Details */ = {

This file was deleted.

Large diffs are not rendered by default.

@@ -0,0 +1,37 @@
//
// NumuUIButton.swift
// Numu Tracker
//
// Created by Bradley Root on 10/16/16.
// Copyright © 2016 Numu Tracker. All rights reserved.
//
import UIKit

class NumuUIButton: UIButton {

override init(frame: CGRect) {
super.init(frame: frame)
setup()
}

required init?(coder aDecoder: NSCoder) {
super.init(coder: aDecoder)
setup()
}

override var isHighlighted: Bool {
didSet {
self.backgroundColor = isHighlighted ? .selectedCell : .numuBlue
}
}

func setup() {
self.layer.cornerRadius = self.frame.size.height/2
self.clipsToBounds = true
self.backgroundColor = .numuBlue
self.titleLabel?.font = UIFont.boldSystemFont(ofSize: 15)
self.contentEdgeInsets = UIEdgeInsets(top: 0, left: 32, bottom: 0, right: 32)
}

}
@@ -49,7 +49,7 @@ class ArtistReleaseTableViewCell: UITableViewCell {

self.selectionStyle = .default
let bgColorView = UIView()
bgColorView.backgroundColor = UIColor(red: 0.17, green: 0.17, blue: 0.17, alpha: 1.0)
bgColorView.backgroundColor = .selectedCell
self.selectedBackgroundView = bgColorView

}
@@ -50,7 +50,7 @@ class ArtistTableViewCell: UITableViewCell {

self.selectionStyle = .default
let bgColorView = UIView()
bgColorView.backgroundColor = UIColor(red: 0.17, green: 0.17, blue: 0.17, alpha: 1.0)
bgColorView.backgroundColor = .selectedCell
self.selectedBackgroundView = bgColorView
}

@@ -206,16 +206,6 @@ class ArtistsTableViewController: UITableViewController, UISearchBarDelegate, UI

self.view?.snapshotView(afterScreenUpdates: true)

importAppleMusicButton.backgroundColor = .clear
importAppleMusicButton.layer.cornerRadius = 5
importAppleMusicButton.layer.borderWidth = 1
importAppleMusicButton.layer.borderColor = UIColor.gray.cgColor

importSpotifyButton.backgroundColor = .clear
importSpotifyButton.layer.cornerRadius = 5
importSpotifyButton.layer.borderWidth = 1
importSpotifyButton.layer.borderColor = UIColor.gray.cgColor

var newFrame = noResultsView.frame
var height: CGFloat = self.tableView.bounds.height
height -= UIApplication.shared.statusBarFrame.size.height
@@ -175,16 +175,6 @@ class AllReleasesTableViewController: UITableViewController {

self.tableView.tableFooterView = self.footerView

importFromAMButton.backgroundColor = .clear
importFromAMButton.layer.cornerRadius = 5
importFromAMButton.layer.borderWidth = 1
importFromAMButton.layer.borderColor = UIColor.gray.cgColor

importSpotifyButton.backgroundColor = .clear
importSpotifyButton.layer.cornerRadius = 5
importSpotifyButton.layer.borderWidth = 1
importSpotifyButton.layer.borderColor = UIColor.gray.cgColor

var newFrame = noResultsFooterView.frame
var height: CGFloat = self.tableView.bounds.height
height -= UIApplication.shared.statusBarFrame.size.height
@@ -58,7 +58,7 @@ class ReleaseTableViewCell: UITableViewCell {

self.selectionStyle = .default
let bgColorView = UIView()
bgColorView.backgroundColor = UIColor(red: 0.17, green: 0.17, blue: 0.17, alpha: 1.0)
bgColorView.backgroundColor = .selectedCell
self.selectedBackgroundView = bgColorView

}
@@ -55,23 +55,11 @@ class HelpViewController: UIViewController, MFMailComposeViewControllerDelegate
error: Error?) {
controller.dismiss(animated: true, completion: nil)
}

func setupButton(button: NumuUIButton) {
button.backgroundColor = .clear
button.layer.cornerRadius = 5
button.layer.borderWidth = 1
button.layer.borderColor = UIColor.gray.cgColor
}

override func viewDidLoad() {
super.viewDidLoad()

self.navigationController?.navigationBar.tintColor = .white

setupButton(button: emailDeveloperButton)
setupButton(button: discussOnRedditButtonOutlet)
setupButton(button: joinSlackButton)

Answers.logCustomEvent(withName: "Help View", customAttributes: nil)

}
@@ -33,11 +33,6 @@ class ImportAppleMusicViewController: UIViewController {

self.navigationController?.navigationBar.tintColor = .white

addFromAppleMusic.backgroundColor = .clear
addFromAppleMusic.layer.cornerRadius = 5
addFromAppleMusic.layer.borderWidth = 1
addFromAppleMusic.layer.borderColor = UIColor.gray.cgColor

}

override func didReceiveMemoryWarning() {
@@ -29,10 +29,6 @@ class ImportSpotifyViewController: UIViewController {

override func viewDidLoad() {
super.viewDidLoad()
spotifyButton.backgroundColor = .clear
spotifyButton.layer.cornerRadius = 5
spotifyButton.layer.borderWidth = 1
spotifyButton.layer.borderColor = UIColor.gray.cgColor
}

}
@@ -134,6 +134,8 @@ extension UIView {
extension UIColor {
static let shadow = UIColor(red: 28/255, green: 202/255, blue: 241/255, alpha: 1)
static let background = UIColor(red: 48/255, green: 156/255, blue: 172/255, alpha: 1)
static let numuBlue = UIColor(red: 0.12, green: 0.62, blue: 0.69, alpha: 1.0)
static let selectedCell = UIColor(red: 0.17, green: 0.17, blue: 0.17, alpha: 1.0)
}

extension UIImageView {
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.