Plan for 3.7 Release

[rprouse]

This project is overdue for a release and I think the fix from #223 is serious enough to warrant getting an update out soon. I have set the milestone to Sunday to give us rough timings. @nunit/core-team and @nunit/engine-team, does this sound reasonable?

If there are issues or related PRs that we should consider including in the release, please assign them to the 3.7 milestone so we can track them.

[CharliePoole]

How do you want to handle the chocolatey issue?

[rprouse]

I will admit that I am less bullish on Chocolatey than I used to be, but the PR looks nearly done, so it would be good to include it in our release and start updating Chocolatey with it. It will be a few days until I can get to the release since I want to do the framework hotfix first, so we have time for this. I will review the outstanding PR soon.

[CharliePoole]

I created a branch (issue-207) and pulled in the changes from @Roemer 's branch. Creating the package and installing it locally, it works but I see unexpected failures in the tests. It may be because I'm running NUnit's own tests and there is some strange interaction going on, so I'll have to retry it tomorrow.

In looking at this more closely, however, I see that it may be possible to avoid copying all the extensions into a single package and to use references as we do for the nuget package. I would have to consult with the chocolatey guys to be sure.

Do you feel this has to go out at the same time as the 3.7 release? It seems like we could put out a chocolatey package using the 3.7 binaries at any point after the release.

I'd like to hear why you are not feeling as positive about chocolatey as before. I was thinking of making it the sole binary distribution for the gui.

[ChrisMaddock]

@rprouse - I'm happy with this repo.

Regarding nunit/nunit-distribution#17 - I don't think I'll have time to sort this over the next couple of days, unless you do, could you manually remove the two extraneous files from the zip for this build? It only affects the zip, not the msi.

[agray]

My project is now consuming NUnit 3.7.1 NuGet Package. What version of the NUnit Console MSI should I install to be compatible with this? My console log is hanging:

C:\Jenkins\workspace\FullCircle\Saucery\Saucery3NUnit>"C:\Program Files (x86)\NUnit.org\nunit-console\nunit3-console.exe" Saucery\NUnit\Version3\UnitTests\bin\Release\UnitTests.dll --result:junit-unittests-testsuite.xml;transform=nunit3-junit.xslt --trace=Verbose  
NUnit Console Runner 3.6.1 
Copyright (C) 2017 Charlie Poole

Runtime Environment
   OS Version: Microsoft Windows NT 10.0.14393.0
   CLR Version: 4.0.30319.42000

Test Files
    Saucery\NUnit\Version3\UnitTests\bin\Release\UnitTests.dll

Is there a 3.7.1 version of the NUnit Console coming soon?

[agray]

Attaching my verbose logs:

Saucery3NUnit.zip

[CharliePoole]

There is no intended correlation between the version numbers of the framework, engine and console. Right now, for example, the NUnit team runs all it's NUnit 3.7.1 and beyond tests using the 3.6.1 console.

Looking at your logs, it seems that the hang takes place when you reach your FlowControlTest. If you examine this and still feel it may be an NUnit problem, please create a new issue rather than piggybacking on this one.

[jnm2]

I am running into the SocketException bug fixed by #223 over and over when I run the build script for the NUnit framework. I haven't gotten a clean run in the last four tries. How soon do you think we can get at least that fix out?

[jnm2]

Hmm, it's to the point where I can't test net20 - net45 using build.cake at all.

[CharliePoole]

@jnm2 We should join forces - I can only test net20 - net45. 😺

[rprouse]

@nunit/engine-team I am planning on doing the 3.7 release on Thursday. If anyone sees an issue with that, please speak up 😄