[CI] Revert to running .NET Standard Engine Tests via NUnitLite #779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 1, 2020
Merged
ChrisMaddock
force-pushed
the
engine-test-fix
branch
3 times, most recently
from
3f9d1b9
to
924848c
Compare
|
Ok - I believe this is now the correct behaviour for CI. The failures I mentioned previously are incorrect, which I take to mean there is a further issue with the .NET Core console. I'll need to come back to that one another day - but this particular PR is now ready for review. One small step at a time. 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately #710 seems to have also affected our own tests. Since #696, I don't think we've actually been running the .NET Standard 1.6 tests, as the console runner has instead been picking up the assembly of the same name in it's own directory - which is the .NET Standard 2.0 test suite. I only noticed as I was getting some weird results working on #710 - and then spotted the two test runs were reporting the same number of tests.
This reverts to running the .NET Standard tests under NUnitLite, as we previously did. (With some added CI changes to install a .NET Core 1.1 runtime, which have been lost along the way.)
It raises an interesting question about the resilience of our own tests. Perhaps we should instead start using the latest NuGet release of the NUnit Console to run the tests...