From b547005be6f6fad4c1eafa92654b24e451f92bf3 Mon Sep 17 00:00:00 2001 From: Charlie Poole Date: Tue, 5 Mar 2019 09:47:10 +0100 Subject: [PATCH 1/2] Eliminate use of ProjectService in agents as well as from AbstractTestRunner --- src/NUnitEngine/nunit-agent/Program.cs | 1 - src/NUnitEngine/nunit.engine/Runners/AbstractTestRunner.cs | 3 --- 2 files changed, 4 deletions(-) diff --git a/src/NUnitEngine/nunit-agent/Program.cs b/src/NUnitEngine/nunit-agent/Program.cs index f05840de4..afe3b6fd5 100644 --- a/src/NUnitEngine/nunit-agent/Program.cs +++ b/src/NUnitEngine/nunit-agent/Program.cs @@ -123,7 +123,6 @@ public static void Main(string[] args) //log.Info("Adding Services"); engine.Services.Add(new SettingsService(false)); engine.Services.Add(new ExtensionService()); - engine.Services.Add(new ProjectService()); engine.Services.Add(new DomainManager()); engine.Services.Add(new InProcessTestRunnerFactory()); engine.Services.Add(new DriverService()); diff --git a/src/NUnitEngine/nunit.engine/Runners/AbstractTestRunner.cs b/src/NUnitEngine/nunit.engine/Runners/AbstractTestRunner.cs index 5db3ed4d3..61d95260d 100644 --- a/src/NUnitEngine/nunit.engine/Runners/AbstractTestRunner.cs +++ b/src/NUnitEngine/nunit.engine/Runners/AbstractTestRunner.cs @@ -39,7 +39,6 @@ public AbstractTestRunner(IServiceLocator services, TestPackage package) { Services = services; TestRunnerFactory = Services.GetService(); - ProjectService = Services.GetService(); TestPackage = package; } @@ -50,8 +49,6 @@ public AbstractTestRunner(IServiceLocator services, TestPackage package) /// protected IServiceLocator Services { get; private set; } - protected IProjectService ProjectService { get; private set; } - protected ITestRunnerFactory TestRunnerFactory { get; private set; } /// From 8abe14098d952fef076cf427de40b9f75600f35d Mon Sep 17 00:00:00 2001 From: Charlie Poole Date: Thu, 7 Mar 2019 11:24:07 +0100 Subject: [PATCH 2/2] Remove agent refrence toSettingsService --- src/NUnitEngine/nunit-agent/Program.cs | 1 - 1 file changed, 1 deletion(-) diff --git a/src/NUnitEngine/nunit-agent/Program.cs b/src/NUnitEngine/nunit-agent/Program.cs index afe3b6fd5..29bf0b0d7 100644 --- a/src/NUnitEngine/nunit-agent/Program.cs +++ b/src/NUnitEngine/nunit-agent/Program.cs @@ -121,7 +121,6 @@ public static void Main(string[] args) // Custom Service Initialization //log.Info("Adding Services"); - engine.Services.Add(new SettingsService(false)); engine.Services.Add(new ExtensionService()); engine.Services.Add(new DomainManager()); engine.Services.Add(new InProcessTestRunnerFactory());