Skip to content

Add --labels switch changes to nunilite and nunitlite tests #1830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
oznetmaster opened this issue Oct 10, 2016 · 9 comments
Closed

Add --labels switch changes to nunilite and nunitlite tests #1830

oznetmaster opened this issue Oct 10, 2016 · 9 comments

Comments

@oznetmaster
Copy link
Contributor

oznetmaster commented Oct 10, 2016

As per @CharliePoole, I am opening this issue to make sure that the --label changes (issue24 nunit/nunit-console#78) made to the console are also made to nunitlite and its tests.

@CharliePoole
Copy link
Member

That's what issue #1829, on which you just commented, is about. :-)

@oznetmaster
Copy link
Contributor Author

No, it is not. One is about --params, the other is about --labels. No relationship at all!

@oznetmaster oznetmaster reopened this Oct 10, 2016
@CharliePoole
Copy link
Member

Sorry... my mistake.

@CharliePoole
Copy link
Member

CharliePoole commented Oct 10, 2016

I corrected the reference in your description, which was not pointing to the --labels issue but to PR #78 in this repository. Use nunit/REPONAME#nn to refer to issues and PRs that are in another repo.

@oznetmaster
Copy link
Contributor Author

I will implement this as soon as the nunit-console PR is merged, and my pending PR for @filename is merged, since it also modifies the same files as need to be modified for this.

@CharliePoole
Copy link
Member

@oznetmaster We're still waiting for comments on that console PR about --labels, regarding a possible change to what we show for each option. It would be great to hear from you and @rprouse, as well as others!

@oznetmaster
Copy link
Contributor Author

I am actually indifferent to the decision. As long as the desired information is available by selecting the correct set of options, the rest is syntactic sugaring.

@oznetmaster
Copy link
Contributor Author

Any progress on getting the console version of this merged?

@CharliePoole
Copy link
Member

This is issue nunit/nunit-console#24 and PR nunit/nunit-console#124, which are still being worked on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants