Skip to content

Investigate removing SpecialValue #1963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ChrisMaddock opened this issue Jan 8, 2017 · 2 comments
Closed

Investigate removing SpecialValue #1963

ChrisMaddock opened this issue Jan 8, 2017 · 2 comments

Comments

@ChrisMaddock
Copy link
Member

SpecialValue.cs has the comment:

/// Null represents a null value, which cannot be 
/// used as an argument to an attribute under .NET 1.x

We no longer support .NET 1.x, so we should check if there are any uncommented dependencies, and whether it can be removed.

There's also a very similar NUnitNullType - perhaps these can be combined, if SpecialValue can't be removed.

@CharliePoole
Copy link
Member

IIRC @rprouse added NUnitNullType for internal processing, whereas SpecialValue was originally intended for users to use.

@CharliePoole
Copy link
Member

It looks to me as if this can be gotten rid of. It was intended for users to use as an argument to a TestCaseAttribute in .NET 1.x. There are references to eliminate, as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants