Skip to content

Switch CHANGES.txt to Markdown #1971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rprouse opened this issue Jan 10, 2017 · 15 comments
Closed

Switch CHANGES.txt to Markdown #1971

rprouse opened this issue Jan 10, 2017 · 15 comments

Comments

@rprouse
Copy link
Member

rprouse commented Jan 10, 2017

Our CHANGES.txt is currently nearly in Markdown format except for the headings. When the changes are copied into releases or the release notes in the docs, they need to be modified to Markdown format. I propose that we just switch CHANGES.txt to CHANGES.md and format it accordingly.

I am putting this out there as an idea. If the @nunit/core-team likes the idea, we can create issues for the other repos that have CHANGES files.

@CharliePoole
Copy link
Member

The changes for release notes are pretty minimal. I've always thought of the file as primarily for the purpose of distribution to users in our packages, where text seems to make more sense.

@ChrisMaddock
Copy link
Member

I think markdown is readable enough as plain text - and anything which saves work is a bonus. I like the idea!

@smwentum
Copy link
Contributor

can i try?

@smwentum smwentum mentioned this issue Jan 16, 2017
@ChrisMaddock
Copy link
Member

Let's make a decision here, so we can handle @smwentum's pull request 😄

@nunit/core-team @nunit/framework-team - any further opinions? @CharliePoole - how averse to the change are you?

As above, my personal thoughts are that the benefit of doing this would outweigh the negative.

@CharliePoole
Copy link
Member

I really don't see this as a useful improvement for users. It's not a file that GitHub treats specially and we already have the release notes for those who view it online.

So the reason to do it is because we want to make our own lives easier. Fair enough. But why focus on making the manual process we hope to replace easier?

Still, I'd be OK with it if we can remember to keep it legible as text by using only very simple markdown.

@rprouse
Copy link
Member Author

rprouse commented Jan 16, 2017

I only propose that we add the # characters for the titles and change the extension to MD. I think the hash characters don't detract much from TXT readability. Users can also click on the CHANGES.md file in GitHub to see a formatted version.

Our target audience is also developers, many of which will have Markdown support enabled in Visual Studio.

@ChrisMaddock
Copy link
Member

I think ideally we'd want to keep the current format - save changing everything/having mixed formats for older releases. That would look like this, raw:

###NUnit 3.6 - January 9, 2017

This release of the framework no longer includes builds for Compact Framework or for SilverLight, but adds a .NET Standard 1.6 build. If anyone still using Compact Framework or SilverLight and would like to continue development on those versions of the framework, please contact the NUnit team.

####Framework

 * .NET Standard 1.6 is now supported

####Issues Resolved

 * 406 Warning-level Assertions
...

@CharliePoole
Copy link
Member

Fair enough...

I didn't know that there was markdown support for VS. I'll have to try it.

@jnm2
Copy link
Contributor

jnm2 commented Jan 16, 2017

I think having a space after the hashes is slightly more readable as plain text:

### NUnit 3.6 - January 9, 2017

This release of the framework no longer includes builds for Compact Framework or for SilverLight, but adds a .NET Standard 1.6 build. If anyone still using Compact Framework or SilverLight and would like to continue development on those versions of the framework, please contact the NUnit team.

#### Framework

 * .NET Standard 1.6 is now supported

#### Issues Resolved

 * 406 Warning-level Assertions
...

That is the big strength of markdown, is that it can be formatted but it's also just as easy to read in plain text. I write markdown in plain text files all the time.

@jnm2
Copy link
Contributor

jnm2 commented Jan 16, 2017

Btw, I just discovered that you can do this:

```markdown
#### This

 * Will be syntax highlighted
```

Produces:

#### This

 * Will be syntax highlighted

@rprouse
Copy link
Member Author

rprouse commented Jan 16, 2017

I didn't know that there was markdown support for VS. I'll have to try it.

It requires an extension, but it is part of the web tools by Mads Kristensen and is one of the more popular extensions, https://marketplace.visualstudio.com/items?itemName=MadsKristensen.MarkdownEditor

Visual Studio Code also support Markdown out of the box. I tend to use it these days.

@ChrisMaddock
Copy link
Member

I think we've made a decision here. I'll update the Pull Request.

@ChrisMaddock
Copy link
Member

Here's a summary of what we think this should involve:

Here's what we think the best plan of action is:

  1. Convert CHANGES.md to CHANGES.txt, and just keep a single file. The references should also be updated in the solution too.

  2. Format the new CHANGES.md as the current formatting in the docs repo - this means 3rd level headers for the main headers, and 4th level for the sub headers. The result should follow this style:

### NUnit 3.6 - January 9, 2017

This release of the framework no longer includes builds for Compact Framework or for SilverLight, but adds a .NET Standard 1.6 build. If anyone still using Compact Framework or SilverLight and would like to continue development on those versions of the framework, please contact the NUnit team.

#### Framework

 * .NET Standard 1.6 is now supported

#### Issues Resolved

 * 406 Warning-level Assertions
...
  1. CHANGES.TXT is also referenced in our nuspec files, and build script - there are three references in the below files which will also need updating.
    https://github.com/nunit/nunit/blob/f35783fc5463d003a24619c82d9fbe55e6290eab/nuget/nunitlite/nunitlite.nuspec
    https://github.com/nunit/nunit/blob/f35783fc5463d003a24619c82d9fbe55e6290eab/nuget/framework/nunit.nuspec
    https://github.com/nunit/nunit/blob/f35783fc5463d003a24619c82d9fbe55e6290eab/build.cake

@smwentum
Copy link
Contributor

sure but it might have to wait until tommorw

@ChrisMaddock
Copy link
Member

No rush - will leave it with you. Thanks! 👍

smwentum added a commit to smwentum/nunit that referenced this issue Jan 22, 2017
ChrisMaddock pushed a commit that referenced this issue Apr 6, 2017
@ChrisMaddock ChrisMaddock added this to the 3.7 milestone Apr 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants