-
Notifications
You must be signed in to change notification settings - Fork 743
Switch CHANGES.txt to Markdown #1971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
The changes for release notes are pretty minimal. I've always thought of the file as primarily for the purpose of distribution to users in our packages, where text seems to make more sense. |
I think markdown is readable enough as plain text - and anything which saves work is a bonus. I like the idea! |
can i try? |
Let's make a decision here, so we can handle @smwentum's pull request 😄 @nunit/core-team @nunit/framework-team - any further opinions? @CharliePoole - how averse to the change are you? As above, my personal thoughts are that the benefit of doing this would outweigh the negative. |
I really don't see this as a useful improvement for users. It's not a file that GitHub treats specially and we already have the release notes for those who view it online. So the reason to do it is because we want to make our own lives easier. Fair enough. But why focus on making the manual process we hope to replace easier? Still, I'd be OK with it if we can remember to keep it legible as text by using only very simple markdown. |
I only propose that we add the # characters for the titles and change the extension to MD. I think the hash characters don't detract much from TXT readability. Users can also click on the Our target audience is also developers, many of which will have Markdown support enabled in Visual Studio. |
I think ideally we'd want to keep the current format - save changing everything/having mixed formats for older releases. That would look like this, raw:
|
Fair enough... I didn't know that there was markdown support for VS. I'll have to try it. |
I think having a space after the hashes is slightly more readable as plain text: ### NUnit 3.6 - January 9, 2017
This release of the framework no longer includes builds for Compact Framework or for SilverLight, but adds a .NET Standard 1.6 build. If anyone still using Compact Framework or SilverLight and would like to continue development on those versions of the framework, please contact the NUnit team.
#### Framework
* .NET Standard 1.6 is now supported
#### Issues Resolved
* 406 Warning-level Assertions
... That is the big strength of markdown, is that it can be formatted but it's also just as easy to read in plain text. I write markdown in plain text files all the time. |
Btw, I just discovered that you can do this:
Produces: #### This
* Will be syntax highlighted |
It requires an extension, but it is part of the web tools by Mads Kristensen and is one of the more popular extensions, https://marketplace.visualstudio.com/items?itemName=MadsKristensen.MarkdownEditor Visual Studio Code also support Markdown out of the box. I tend to use it these days. |
I think we've made a decision here. I'll update the Pull Request. |
Here's a summary of what we think this should involve: Here's what we think the best plan of action is:
### NUnit 3.6 - January 9, 2017
This release of the framework no longer includes builds for Compact Framework or for SilverLight, but adds a .NET Standard 1.6 build. If anyone still using Compact Framework or SilverLight and would like to continue development on those versions of the framework, please contact the NUnit team.
#### Framework
* .NET Standard 1.6 is now supported
#### Issues Resolved
* 406 Warning-level Assertions
...
|
sure but it might have to wait until tommorw |
No rush - will leave it with you. Thanks! 👍 |
… the references. See issue nunit#1971 for more details
… the references. See issue #1971 for more details
Our
CHANGES.txt
is currently nearly in Markdown format except for the headings. When the changes are copied into releases or the release notes in the docs, they need to be modified to Markdown format. I propose that we just switchCHANGES.txt
toCHANGES.md
and format it accordingly.I am putting this out there as an idea. If the @nunit/core-team likes the idea, we can create issues for the other repos that have CHANGES files.
The text was updated successfully, but these errors were encountered: