New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for NUnit vs .Net Core projects in VS 2017. #2077

Closed
dmitriyse opened this Issue Mar 12, 2017 · 10 comments

Comments

Projects
None yet
5 participants
@dmitriyse

dmitriyse commented Mar 12, 2017

Currently NUnit test adapter works only with .Net Framework 4.0+ projects in VS 2017.
Please add full support for .Net core projects under VS 2017.
xUnit works with .net Core under VS 2017 RC (+ with R#) more than half of a year.
Please do not force our team to switch to xUnit. We will never back again.
P.S. Probably this is duplicate issue.

@dmitriyse

This comment has been minimized.

Show comment
Hide comment
@dmitriyse

dmitriyse Mar 12, 2017

NUnit is the last brick in a puzzle. It's block us from migrating to VS 2017 and C# 7.0.

dmitriyse commented Mar 12, 2017

NUnit is the last brick in a puzzle. It's block us from migrating to VS 2017 and C# 7.0.

@CharliePoole

This comment has been minimized.

Show comment
Hide comment
@CharliePoole

CharliePoole Mar 12, 2017

Member

We recognize this as a very important issue. It's being tracked by several issues already, in the nunit3-vs-adapter repository. The framework support (this repo) is already there.

Member

CharliePoole commented Mar 12, 2017

We recognize this as a very important issue. It's being tracked by several issues already, in the nunit3-vs-adapter repository. The framework support (this repo) is already there.

@dmitriyse

This comment has been minimized.

Show comment
Hide comment
@dmitriyse

dmitriyse Mar 12, 2017

Thank you. Glad to hear that NUnit team aware of this problem.
Does nunit3-vs-adapter project have some working developer build ?

dmitriyse commented Mar 12, 2017

Thank you. Glad to hear that NUnit team aware of this problem.
Does nunit3-vs-adapter project have some working developer build ?

@rprouse

This comment has been minimized.

Show comment
Hide comment
@rprouse

rprouse Mar 12, 2017

Member

We don't have a working developer build yet. First we need a .NET Standard version of our engine which I am working on now. Once that is done, we just need to plug it into the adapter.

To hold you over, you could temporarily make your unit tests self executing with NUnitLite.

Member

rprouse commented Mar 12, 2017

We don't have a working developer build yet. First we need a .NET Standard version of our engine which I am working on now. Once that is done, we just need to plug it into the adapter.

To hold you over, you could temporarily make your unit tests self executing with NUnitLite.

@dmitriyse

This comment has been minimized.

Show comment
Hide comment
@dmitriyse

dmitriyse Mar 12, 2017

Unfortunately this solution does not fit to our development workflow. We are hardly depends on ability to run tests solely with debug.

dmitriyse commented Mar 12, 2017

Unfortunately this solution does not fit to our development workflow. We are hardly depends on ability to run tests solely with debug.

@dmitriyse

This comment has been minimized.

Show comment
Hide comment
@dmitriyse

dmitriyse Mar 12, 2017

VS 2015 + toolset satisfy us. So we can wait NUnit adoption to VS 2017/Net Standard. But than later we will start migration than more code is to be reworked.

dmitriyse commented Mar 12, 2017

VS 2015 + toolset satisfy us. So we can wait NUnit adoption to VS 2017/Net Standard. But than later we will start migration than more code is to be reworked.

@JustinRChou

This comment has been minimized.

Show comment
Hide comment
@JustinRChou

JustinRChou Mar 12, 2017

Contributor

@dmitriyse
How is that migration process?
From what I have looked up, it does seem that you have to recreate the whole project in VS2017 as it doesn't seem to do a project conversion for you?

Contributor

JustinRChou commented Mar 12, 2017

@dmitriyse
How is that migration process?
From what I have looked up, it does seem that you have to recreate the whole project in VS2017 as it doesn't seem to do a project conversion for you?

@dmitriyse

This comment has been minimized.

Show comment
Hide comment
@dmitriyse

dmitriyse Mar 12, 2017

project.json -> *.csproj (2017) is only one of multiple migration activities.
2) Second for us is replacing Task to ValueTask in most part of places
** Other things, that cannot be predicted right now **

dmitriyse commented Mar 12, 2017

project.json -> *.csproj (2017) is only one of multiple migration activities.
2) Second for us is replacing Task to ValueTask in most part of places
** Other things, that cannot be predicted right now **

@dmitriyse

This comment has been minimized.

Show comment
Hide comment
@dmitriyse

dmitriyse Mar 28, 2017

Hi! How is your progress? Does any preview build is capable to run DotNet Core NUnit tests in VS 2017 ?

dmitriyse commented Mar 28, 2017

Hi! How is your progress? Does any preview build is capable to run DotNet Core NUnit tests in VS 2017 ?

@ChrisMaddock

This comment has been minimized.

Show comment
Hide comment
@ChrisMaddock

ChrisMaddock Mar 28, 2017

Member

@dmitriyse - It's being worked on at the moment - lots of progress is being made! The two main issues for this are the ones below, I suggest you follow those. I'll close this one as a duplicate.

nunit/nunit-console#10
nunit/nunit3-vs-adapter#297

Member

ChrisMaddock commented Mar 28, 2017

@dmitriyse - It's being worked on at the moment - lots of progress is being made! The two main issues for this are the ones below, I suggest you follow those. I'll close this one as a duplicate.

nunit/nunit-console#10
nunit/nunit3-vs-adapter#297

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment