Allow comments in @FILE files

In the @file files, allow comments. These files could get pretty complex, and having the ability to add comments would be beneficial. Maybe if a line starts with # it's interpreted as a comment? Not sure, just throwing out ideas.

# Black list specific tests we don't want to run
--where "method != /.*_(Blah|Blah2|Blah3)$/"

Great project by the way 👍

[JustinRChou]

@CharliePoole
Is this really a easy fix and wouldn't this involve updating the console runner and the lite runner?

And this is probably extra work but would it make sense to write the comment into the TestResult.xml?

[CharliePoole]

I was thinking of this as a console issue but you're right that it applies to NUnitLite as well.

In the console, it's extremely easy to just ignore a full line starting with # - looks like a change of one line. Doing more is possible, but difficult since the individual line can contain # (or any other characters) in quotes. The format was designed to be simple and we probably shouldn't complicate it, since that would require a redesign without a clear benefit.

The NUnitLite implementation is entirely different and treats the entire file as a single string. That looks like an easyfix as well, but more than a single line.

I'll duplicate this under the console as well.

Thanks @CharliePoole and @JustinRChou!

[JustinRChou]

I am going to work on this.

And I am having trouble finding tests for the @File option?

[CharliePoole]

https://github.com/nunit/nunit/blob/master/src/NUnitFramework/nunitlite.tests/CommandLineTests.cs#L44

[JustinRChou]

I just saw the update for the console one nunit/nunit-console#202
Probably going to do a compare and move your changes over.

[JustinRChou]

@CharliePoole I tried moving your testcases over to AtsignFilenameTests but the existing testcases are already failing when I am running them in the Test Explorer but build -t test looks fine.

I don't know what is going on here.

[CharliePoole]

@JustinRChou Have you run nunit tests under the TestExplorer before? I would be very surprised if that worked at all. When testing NUnit, we always tell people to stick with just the basics, no "third-party" stuff - which is kind of what the VS adapter is, although it belongs to us.

As far as the @file implementation, it is of course entirely different in the two programs, developed by two different people.

[JustinRChou]

Oh, that really explains a lot when I was working on the framework test cases.

[JustinRChou]

Looks like

        internal static IEnumerable<string> GetArgs(string commandLine)
        {
            const string re = @"\G(""((""""|[^""])+)""|(\S+)) *";
            var ms = Regex.Matches(commandLine, re);
            return ms.Cast<Match>().Select(m => Regex.Replace(m.Groups[2].Success ? m.Groups[2].Value : m.Groups[4].Value, @"""""", @""""));
        }

is having issues dealing with spaces in #This is a comment, it does a split on the spaces so the result becomesis a comment .

[CharliePoole]

You may have to reimplement it in line with the console runner.