Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upStackFIlter trims leading spaces from each line #2208
Comments
CharliePoole
added
good first issue
is:bug
pri:low
labels
May 30, 2017
added a commit
to mikkelbu/nunit
that referenced
this issue
Jun 8, 2017
jnm2
closed this
in
#2235
Jun 9, 2017
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
oznetmaster
Jun 12, 2017
Contributor
It seems like this fix is in the wrong place, and assumes that every stack trace line starts with whitespace, and the same whitespace.
If that ever changes, then this will break again.
Correct fix seems to be to Trim everything, and then format the reports correctly.
|
It seems like this fix is in the wrong place, and assumes that every stack trace line starts with whitespace, and the same whitespace. If that ever changes, then this will break again. Correct fix seems to be to Trim everything, and then format the reports correctly. |
rprouse
added
the
closed:done
label
Jul 24, 2017
rprouse
added this to the 3.8 milestone
Jul 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
CharliePoole commentedMay 30, 2017
I noticed in the gui that stack traces from a test failure were showing up without leading spaces before the "at" on each line, whereas error failures had it. I confirmed same behavior on the console. While not terribly important, this does make the reports of combined failures and errors look odd.
I think it's due to a
Trim()call in StackFilter.cs, which should probably simply be eliminated.