New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StackFIlter trims leading spaces from each line #2208

Closed
CharliePoole opened this Issue May 30, 2017 · 1 comment

Comments

Projects
None yet
3 participants
@CharliePoole
Member

CharliePoole commented May 30, 2017

I noticed in the gui that stack traces from a test failure were showing up without leading spaces before the "at" on each line, whereas error failures had it. I confirmed same behavior on the console. While not terribly important, this does make the reports of combined failures and errors look odd.

I think it's due to a Trim() call in StackFilter.cs, which should probably simply be eliminated.

@oznetmaster

This comment has been minimized.

Show comment
Hide comment
@oznetmaster

oznetmaster Jun 12, 2017

Contributor

It seems like this fix is in the wrong place, and assumes that every stack trace line starts with whitespace, and the same whitespace.

If that ever changes, then this will break again.

Correct fix seems to be to Trim everything, and then format the reports correctly.

Contributor

oznetmaster commented Jun 12, 2017

It seems like this fix is in the wrong place, and assumes that every stack trace line starts with whitespace, and the same whitespace.

If that ever changes, then this will break again.

Correct fix seems to be to Trim everything, and then format the reports correctly.

@rprouse rprouse added the closed:done label Jul 24, 2017

@rprouse rprouse added this to the 3.8 milestone Jul 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment