-
Notifications
You must be signed in to change notification settings - Fork 748
Switch to one Release branch #2222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
As a third option, if we tag on master, then we don't need to keep any release branch after it is merged. Create a 3.8 branch Because of how we do versioning, that part of it is a little messy, but no worse than what we now do. If we could get away from keeping the version in the repo, then it would be a lot easier. |
I like both your and @CharliePoole's suggestions. |
This is where you need a BD. 😄 |
I also like @CharliePoole's suggestion although it will require some change to our build process. My only concern with that suggestion is that it could result in CI builds creating new builds using the released build number (plus the CI identifiers) after a release since we usually increment the version number post release. I would like to see us get to a point where tagging a release builds it on AppVeyor and we just download and test the artifacts before releasing to NuGet. I would like to see us get away from developers building and testing on their own machines. @OsirisTerje has setup an initial build in VSTS, we could even use the build and release management there to fully automate the build and release. It is about time we became more DevOps'y 😄 |
Closing, we are now on one release branch. |
@rprouse This issue is still open. Did you mean to |
I'll close the issue, as the comment and label indicates that it is closed :) |
Thanks |
Proposing this as an idea pending discussion and testing.
We are currently creating a release branch for every major release, then adding commits to those release branches for hotfixes. This is working but we are accumulating many branches that we are unlikely to use anymore because we only ever create hotfixes on the latest release. We also have tags for every release, so we can always get back to them.
My proposal is that we delete old
release/3.x
branches. Next, one of two options,release/3.7
branch torelease
. As we prepare each release, we either directly merge latest from master into the release branch, or create a PR to do so.release/3.x
format for releases and delete old release branches once a new release is out.I like the idea of a long running release branch (option 1), but option 2 has the advantage that it doesn't change our current release process and only requires a small update to our docs. It is probably also the simplest option.
Assigning to myself. My idea, I will do the work if want to do this.
The text was updated successfully, but these errors were encountered: