Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upIntermittent test failures in Travic CI: TestContextTests #2276
Comments
CharliePoole
added
is:bug
pri:high
labels
Jun 22, 2017
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
ChrisMaddock
Jun 22, 2017
Member
These have been flakey on Mono/Travis before, and I've really no idea why.
They've never had a problem on Appveyor, and I can't work out any logic issues with parallelisation.
The especially weird ones are the ones where file file exists for one test, but not for the next - the file should be created and disposed of in the OneTimeSetUp and OneTimeTearDown - so I'm really not sure what's going on there. :-/
|
These have been flakey on Mono/Travis before, and I've really no idea why. They've never had a problem on Appveyor, and I can't work out any logic issues with parallelisation. The especially weird ones are the ones where file file exists for one test, but not for the next - the file should be created and disposed of in the OneTimeSetUp and OneTimeTearDown - so I'm really not sure what's going on there. :-/ |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
CharliePoole
Jun 22, 2017
Member
Parallelization is what it is. TestContextTests and TestAttachmentTests are creating and using the same file name. Best to use GetTempFileName().
|
Parallelization is what it is. TestContextTests and TestAttachmentTests are creating and using the same file name. Best to use GetTempFileName(). |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Ahhh - thanks! I'll PR at some point. |
CharliePoole commentedJun 22, 2017
Failure is in new tests added in relation to attachments...
FilePathOnlyDoesNotThrowFilePathAndDescriptionDoesNotThrowSee https://travis-ci.org/nunit/nunit/jobs/245882030