Skip to content

Intermittent test failures in Travic CI: TestContextTests #2276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
CharliePoole opened this issue Jun 22, 2017 · 3 comments · Fixed by #2277
Closed

Intermittent test failures in Travic CI: TestContextTests #2276

CharliePoole opened this issue Jun 22, 2017 · 3 comments · Fixed by #2277
Assignees
@ChrisMaddock
Labels
closed:done is:bug pri:high
Milestone
3.8

Comments

@CharliePoole
Copy link
Member

Failure is in new tests added in relation to attachments...

  • FilePathOnlyDoesNotThrow
  • FilePathAndDescriptionDoesNotThrow

See https://travis-ci.org/nunit/nunit/jobs/245882030
@ChrisMaddock
Copy link
Member

These have been flakey on Mono/Travis before, and I've really no idea why. 😞

They've never had a problem on Appveyor, and I can't work out any logic issues with parallelisation.

The especially weird ones are the ones where file file exists for one test, but not for the next - the file should be created and disposed of in the OneTimeSetUp and OneTimeTearDown - so I'm really not sure what's going on there. :-/

@CharliePoole
Copy link
Member Author

Parallelization is what it is. TestContextTests and TestAttachmentTests are creating and using the same file name. Best to use GetTempFileName().

@ChrisMaddock
Copy link
Member

Ahhh - thanks! I'll PR at some point.

@ChrisMaddock ChrisMaddock self-assigned this Jun 23, 2017
@ChrisMaddock ChrisMaddock added this to the 3.8 milestone Jun 23, 2017
@ChrisMaddock ChrisMaddock mentioned this issue Jun 23, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChrisMaddock ChrisMaddock

Labels
closed:done is:bug pri:high
Projects
None yet
Milestone
3.8
Development

Successfully merging a pull request may close this issue.

Use unique names for each TestAttachments Fixture nunit/nunit
2 participants
@CharliePoole @ChrisMaddock