New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intermittent test failures in Travic CI: TestContextTests #2276

Closed
CharliePoole opened this Issue Jun 22, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@CharliePoole
Member

CharliePoole commented Jun 22, 2017

Failure is in new tests added in relation to attachments...

  • FilePathOnlyDoesNotThrow
  • FilePathAndDescriptionDoesNotThrow

See https://travis-ci.org/nunit/nunit/jobs/245882030

@ChrisMaddock

This comment has been minimized.

Show comment
Hide comment
@ChrisMaddock

ChrisMaddock Jun 22, 2017

Member

These have been flakey on Mono/Travis before, and I've really no idea why. 😞

They've never had a problem on Appveyor, and I can't work out any logic issues with parallelisation.

The especially weird ones are the ones where file file exists for one test, but not for the next - the file should be created and disposed of in the OneTimeSetUp and OneTimeTearDown - so I'm really not sure what's going on there. :-/

Member

ChrisMaddock commented Jun 22, 2017

These have been flakey on Mono/Travis before, and I've really no idea why. 😞

They've never had a problem on Appveyor, and I can't work out any logic issues with parallelisation.

The especially weird ones are the ones where file file exists for one test, but not for the next - the file should be created and disposed of in the OneTimeSetUp and OneTimeTearDown - so I'm really not sure what's going on there. :-/

@CharliePoole

This comment has been minimized.

Show comment
Hide comment
@CharliePoole

CharliePoole Jun 22, 2017

Member

Parallelization is what it is. TestContextTests and TestAttachmentTests are creating and using the same file name. Best to use GetTempFileName().

Member

CharliePoole commented Jun 22, 2017

Parallelization is what it is. TestContextTests and TestAttachmentTests are creating and using the same file name. Best to use GetTempFileName().

@ChrisMaddock

This comment has been minimized.

Show comment
Hide comment
@ChrisMaddock

ChrisMaddock Jun 23, 2017

Member

Ahhh - thanks! I'll PR at some point.

Member

ChrisMaddock commented Jun 23, 2017

Ahhh - thanks! I'll PR at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment