Write TestParametersDictionary to xml result file in readable format

[ChrisMaddock]

I just went to look up TestParameters in the results xml.

<setting name="TestParameters" value="1=d;2=e" />
<setting name="TestParametersDictionary" value="System.Collections.Generic.Dictionary`2[System.String,System.String]" />

It would be good if we can write that out TestParametersDictionary in a more readable fashion in the TestResult xml - the current output isn't much use.

[oznetmaster]

I was not aware that it was deprecated, informally or formally :(

[ChrisMaddock]

Did I get it the wrong way around? I thought you were one of the key people pushing for it @oznetmaster! 😄

I lost track of all the debate that went into that one, but I thought one of TestParameters/TestParametersDictionary was intended to replace the other - but both were going to continue to be supported, for runner backwards compatibility? Am I wrong there?

[oznetmaster]

Not at all. I was actually opposed to the addition of TestParameterDictionary.

[ChrisMaddock]

I removed my comment on the matter, given I clearly don't know what I'm on about. 🙂

[CharliePoole]

@ChrisMaddock I'm confused as well, so I guess we are forced to focus on the issue itself. 😄

Old frameworks only understand TestParameters. New frameworks currently understand both. Ideally, both shouldn't be in the XML IMO. They are two representations of the same thing.

Where is the code that adds the settings to the XML? I'm not finding it on my phone.

[ChrisMaddock]

nunit/src/NUnitFramework/framework/Api/FrameworkController.cs

Line 436 in 7b87bdc

private static void AddSetting(TNode settingsNode, string name, object value)

Looks like it just ToString()'s it. Maybe we can do something more intelligent if the 'object' of the setting is a dictionary.

[CharliePoole]

My thought is that the framework should reflect the settings it's actually using. For new frameworks, that's the dictionary. So the legacy setting can easily be ignored. The TestParametersDictionary setting can be handled element by element, giving us something the actual values.