New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect xmldoc on RetryAttribute #2313

Closed
ChrisMaddock opened this Issue Jul 10, 2017 · 3 comments

Comments

Projects
None yet
5 participants
@ChrisMaddock
Member

ChrisMaddock commented Jul 10, 2017

The xmldoc on RetryAttribute has been copy/pasted from RepeatAttribute. This should be corrected.

https://github.com/nunit/nunit/blob/7b87bdc7b48ee1b13023dd282efea449c2d66b81/src/NUnitFramework/framework/Attributes/RetryAttribute.cs

We already have some doc for RetryAttribute - so this could be a good issue for a first time contributor. 🙂

https://github.com/nunit/docs/wiki/Retry-Attribute

@MhdTlb

This comment has been minimized.

Show comment
Hide comment
@MhdTlb

MhdTlb Jul 11, 2017

Contributor

Can I work on this issue?

Contributor

MhdTlb commented Jul 11, 2017

Can I work on this issue?

@mikkelbu

This comment has been minimized.

Show comment
Hide comment
@mikkelbu

mikkelbu Jul 11, 2017

Member

Sure. I've assigned the issue to you.

Member

mikkelbu commented Jul 11, 2017

Sure. I've assigned the issue to you.

MhdTlb added a commit to MhdTlb/nunit that referenced this issue Jul 12, 2017

@rprouse rprouse closed this in 1446e65 Jul 12, 2017

@jnm2 jnm2 added closed:done and removed help wanted labels Jul 12, 2017

@jnm2

This comment has been minimized.

Show comment
Hide comment
@jnm2

jnm2 Jul 12, 2017

Contributor

@mikkelbu Fyi, we remove the up-for-grabs when we assign people and try to add up-for-grabs (have to document first) whenever it's approved on the backlog and not assigned.

Contributor

jnm2 commented Jul 12, 2017

@mikkelbu Fyi, we remove the up-for-grabs when we assign people and try to add up-for-grabs (have to document first) whenever it's approved on the backlog and not assigned.

@rprouse rprouse modified the milestone: 3.8 Jul 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment