New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated Is.String* Constraints #2342

Closed
ChrisMaddock opened this Issue Aug 1, 2017 · 2 comments

Comments

Projects
None yet
3 participants
@ChrisMaddock
Member

ChrisMaddock commented Aug 1, 2017

#2338 removed the attributes obsoleted in v3.0.

I suggest we also remove the Is.String* constraints which were deprecated at the same time - and do this in the 3.8 release, so we only inconvenience users the once.

@ChrisMaddock ChrisMaddock added this to the 3.8 milestone Aug 1, 2017

@CharliePoole

This comment has been minimized.

Show comment
Hide comment
@CharliePoole

CharliePoole Aug 1, 2017

Member

I've never been happy with our syntax for the four string constraints, but the Is.String* items should definitely go.

Member

CharliePoole commented Aug 1, 2017

I've never been happy with our syntax for the four string constraints, but the Is.String* items should definitely go.

@OmicronPersei

This comment has been minimized.

Show comment
Hide comment
@OmicronPersei

OmicronPersei Aug 10, 2017

Contributor

While I wait for more info on #2226 I'll work on this 😛

Contributor

OmicronPersei commented Aug 10, 2017

While I wait for more info on #2226 I'll work on this 😛

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment