Repository navigation
--labels=All doesn't show anything in console output executing NUnitLite Console Runner #2402
Description
Hello!
Seems I am getting an issue with the --labels=All. Seems this argument is not showing any output while executing the nunitlite console runner (from master 3256c91) over a my test library.
Doing some debugging over the console runner I realized every result here:
https://github.com/nunit/nunit/blob/master/src/NUnitFramework/nunitlite/TextUI.cs#L251
It gets an empty Output value (this is correct?), and because this we never reach _displayBeforeOutput check to show Test.Fullname.
Also @CharliePoole would be fantastic include additional information here like the Duration in the same line, to catch timeout issues or if our runner is killed for some reason and we don't have the result file generated.
Thanks for your hard work guys it's awesome!
Activity
CharliePoole commentedon Aug 31, 2017
Could you clarify exactly what you are running? What is your command-line?
netonjm commentedon Aug 31, 2017
Ops! Sorry. Working from a Mac computer...
mono build/UnitRunner/nunitlite-runner.exe test.dll --labels=All
Fix show output labels when labels=All in runner
CharliePoole commentedon Oct 9, 2017
@ChrisMaddock I already fixed this in my ongoing PR for parallel execution, since I needed it in order to debug. It's a one-line change. Should I do a separate PR for it?
Honor --labels setting in NUnitLite. Fixes #2402
ChrisMaddock commentedon Oct 9, 2017
@netonjm was going to revisit this - so long as he's aware you've already got it sorted @CharliePoole, sounds good to me!
Will leave it up to you as to whether to separate it out or not, I don't have any particular objection to it not being.
netonjm commentedon Oct 10, 2017
Sounds good to me 👍 !
Thanks @CharliePoole !
mikkelbu commentedon Oct 10, 2017
Hi @netonjm. The issue has automatically closed due to #2482. Regarding the wish for additional information in the labels, I think that this is best addressed in a new issue, as this is not a bug, but an improvement.