Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--labels=All doesn't show anything in console output executing NUnitLite Console Runner #2402

Closed
netonjm opened this issue Aug 31, 2017 · 6 comments · Fixed by #2482
Closed

Comments

@netonjm
Copy link

netonjm commented Aug 31, 2017

Hello!

Seems I am getting an issue with the --labels=All. Seems this argument is not showing any output while executing the nunitlite console runner (from master 3256c91) over a my test library.

Doing some debugging over the console runner I realized every result here:
https://github.com/nunit/nunit/blob/master/src/NUnitFramework/nunitlite/TextUI.cs#L251

It gets an empty Output value (this is correct?), and because this we never reach _displayBeforeOutput check to show Test.Fullname.

Also @CharliePoole would be fantastic include additional information here like the Duration in the same line, to catch timeout issues or if our runner is killed for some reason and we don't have the result file generated.

Thanks for your hard work guys it's awesome!

@CharliePoole
Copy link
Member

Could you clarify exactly what you are running? What is your command-line?

@netonjm
Copy link
Author

netonjm commented Aug 31, 2017

Ops! Sorry. Working from a Mac computer...

00000246

mono build/UnitRunner/nunitlite-runner.exe test.dll --labels=All

netonjm added a commit to netonjm/nunit that referenced this issue Sep 1, 2017
Fixes Bug nunit#2402
In console runner the result.Output has an empty values
in Passed statements. We want show _displayBeforeOutput
in every case.
@CharliePoole
Copy link
Member

@ChrisMaddock I already fixed this in my ongoing PR for parallel execution, since I needed it in order to debug. It's a one-line change. Should I do a separate PR for it?

@ChrisMaddock
Copy link
Member

ChrisMaddock commented Oct 9, 2017

@netonjm was going to revisit this - so long as he's aware you've already got it sorted @CharliePoole, sounds good to me!

Will leave it up to you as to whether to separate it out or not, I don't have any particular objection to it not being.

@netonjm
Copy link
Author

netonjm commented Oct 10, 2017

Sounds good to me 👍 !
Thanks @CharliePoole !

@mikkelbu
Copy link
Member

Hi @netonjm. The issue has automatically closed due to #2482. Regarding the wish for additional information in the labels, I think that this is best addressed in a new issue, as this is not a bug, but an improvement.

@mikkelbu mikkelbu added this to the 3.9 milestone Oct 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants