-
Notifications
You must be signed in to change notification settings - Fork 742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
--labels=All doesn't show anything in console output executing NUnitLite Console Runner #2402
Comments
Could you clarify exactly what you are running? What is your command-line? |
Fixes Bug nunit#2402 In console runner the result.Output has an empty values in Passed statements. We want show _displayBeforeOutput in every case.
@ChrisMaddock I already fixed this in my ongoing PR for parallel execution, since I needed it in order to debug. It's a one-line change. Should I do a separate PR for it? |
@netonjm was going to revisit this - so long as he's aware you've already got it sorted @CharliePoole, sounds good to me! Will leave it up to you as to whether to separate it out or not, I don't have any particular objection to it not being. |
Sounds good to me 👍 ! |
Hello!
Seems I am getting an issue with the --labels=All. Seems this argument is not showing any output while executing the nunitlite console runner (from master 3256c91) over a my test library.
Doing some debugging over the console runner I realized every result here:
https://github.com/nunit/nunit/blob/master/src/NUnitFramework/nunitlite/TextUI.cs#L251
It gets an empty Output value (this is correct?), and because this we never reach _displayBeforeOutput check to show Test.Fullname.
Also @CharliePoole would be fantastic include additional information here like the Duration in the same line, to catch timeout issues or if our runner is killed for some reason and we don't have the result file generated.
Thanks for your hard work guys it's awesome!
The text was updated successfully, but these errors were encountered: