Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NuGet package links to outdated license #2656

Closed
jnm2 opened this issue Jan 13, 2018 · 7 comments
Closed

NuGet package links to outdated license #2656

jnm2 opened this issue Jan 13, 2018 · 7 comments
Assignees
Milestone

Comments

@jnm2
Copy link
Contributor

jnm2 commented Jan 13, 2018

<licenseUrl>http://nunit.org/nuget/nunit3-license.txt</licenseUrl>

<licenseUrl>http://nunit.org/nuget/nunit3-license.txt</licenseUrl>

http://nunit.org/nuget/nunit3-license.txt:

Copyright (c) 2015 Charlie Poole

Is this URL a good place to maintain the license into the future or should we use https://github.com/nunit/nunit/blob/master/LICENSE.txt?

@ChrisMaddock
Copy link
Member

I agree project specific makes more sense, now different projects are copyrighted in different ways.

@rprouse
Copy link
Member

rprouse commented Jan 15, 2018

Also agree, nuspecs should probably point to the raw files in GitHub for each project.

@jnm2
Copy link
Contributor Author

jnm2 commented Jan 15, 2018

I don't really know what the pros and cons are, but what do you think of linking the GUI version instead of the raw version? https://github.com/nunit/nunit/blob/master/LICENSE.txt

Mostly for this:

image

Though it also gives you this:

image

@rprouse
Copy link
Member

rprouse commented Jan 15, 2018

Interesting question. The raw version is our license, whereas the GUI version is GitHub's interpretation of our license. Their interpretation is correct and I think it adds value, but does linking to that imply acceptance of GitHub's interpretation? Anyone have opinions or experience? The lawyer in me would say that we should link to the raw version, the dev to the GUI version.

Please note, I am not a lawyer, I only play one in issue comments 😄

@ChrisMaddock
Copy link
Member

The lawyer in me would say that we should link to the raw version

I am also not a lawyer, and accordingly would keep a licence as simple as possible. 😄

@jnm2
Copy link
Contributor Author

jnm2 commented Jan 15, 2018

Good point. Raw sounds safest.

@ChrisMaddock ChrisMaddock added this to the 3.10 milestone Jan 22, 2018
@ChrisMaddock
Copy link
Member

This needs to be done in many projects. 😞

Cloning it to just the console for now, so we can get it in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants