You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the NUnit3 console runner 3.7, the argument x.dll gives an error message indicating the file was not found. Typing x.junk gives a message saying that the file type is not known.
In the current master build, the run fails without specifying a message in both cases.
As discussed in PR #177, assembly-level errors like file not found or invalid file type stopped displaying in the console runner with the merging of #326. This is due to the fact that the assembly level normally does not have a site associated with it.
An easy fix was tried but has the drawback that it causes all suites containing a test with a warning, either directly or indirectly, to display as well. That problem is due to the fact that warnings never have a site associated with them either.
This will be a two part fix. The framework has to be updated so that a warning result caused by a child test uses FailureSite.Child In fact, it's essential that any failure or warning of a suite caused by a child test use that value explicitly.
However, even when the framework is updated, the console has to be able to deal with older framework versions that do not set FailureSite correctly. That's what the current issue has to do. Specifically, this issue needs to...
Ensure that assembly errors, failures and warnings are shown in the errors, failures and warnings report
Ensure that warnings are also shown in the report only once, that is, not repeated for the suites that contain them
I'm replicating this same issue to the framework repository for the work that is needed there.
The text was updated successfully, but these errors were encountered:
The framework part of this issue is to ensure that we always use FailureSite.Child when appropriate, for warnings as well as failures. See nunit/nunit-console#350 for the console portion.
@CharliePoole commented on Tue Jan 16 2018
In the NUnit3 console runner 3.7, the argument
x.dll
gives an error message indicating the file was not found. Typingx.junk
gives a message saying that the file type is not known.In the current master build, the run fails without specifying a message in both cases.
@CharliePoole commented on Thu Jan 18 2018
As discussed in PR #177, assembly-level errors like file not found or invalid file type stopped displaying in the console runner with the merging of #326. This is due to the fact that the assembly level normally does not have a site associated with it.
An easy fix was tried but has the drawback that it causes all suites containing a test with a warning, either directly or indirectly, to display as well. That problem is due to the fact that warnings never have a site associated with them either.
This will be a two part fix. The framework has to be updated so that a warning result caused by a child test uses
FailureSite.Child
In fact, it's essential that any failure or warning of a suite caused by a child test use that value explicitly.However, even when the framework is updated, the console has to be able to deal with older framework versions that do not set
FailureSite
correctly. That's what the current issue has to do. Specifically, this issue needs to...Ensure that assembly errors, failures and warnings are shown in the errors, failures and warnings report
Ensure that warnings are also shown in the report only once, that is, not repeated for the suites that contain them
I'm replicating this same issue to the framework repository for the work that is needed there.
The text was updated successfully, but these errors were encountered: