Syntax suggestions errors as warnings

[OmicronPersei]

Looks like my VS2017 is treating some of these as errors, I want to say our .editorconfig settings are probably causing this? Are these intended by chance?

[rprouse]

Do you have latest? We fixed some of these recently. It could also be caused by analyzers you have installed.

[OmicronPersei]

Should be:

$ git log -n 1
commit 259066fb2b8edb753f982a88662834e0c6a09215 (HEAD -> master, nunit-upstream/master)
Merge: faa77153 6b6c7b52
Author: Joseph Musser <me@jnm2.com>
Date:   Wed Jan 31 19:29:35 2018 -1000

    Merge pull request #2692 from OmicronPersei/issue-1578

    Extracted a PropertyBagAdapter on the TestContext.Properties property.

[jnm2]

@OmicronPersei The editorconfig at the commit you mention only causes warnings, no errors: https://github.com/nunit/nunit/blob/259066fb2b8edb753f982a88662834e0c6a09215/.editorconfig

Have you closed and reopened all editor windows after checking out that commit?

[OmicronPersei]

Does closing/opening Visual Studio count? I know they're supposed to be warnings but, at least visually, they look like errors to me.

[jnm2]

Yes, closing and reopening works. Does your checked-out .editorconfig have the word 'error' in it?

[OmicronPersei]

It does not. Maybe someone else can try reproducing this? My workspace is clean so it should be reproducible elsewhere. I can repro both on my desktop and laptop (both Win 10 / VS2017).

[mikkelbu]

I've the same problem. Changing the warning to a suggestion helps, but buth warning and error give rise to an error (and my default VS configuration - overridden by editorconfig - is to have these as warnings)

[rprouse]

I am seeing the same thing, but only when the files are open, for example TestContext.cs. I deleted .editorconfig and reopened the solution and it went away. I am not sure why Visual Studio is showing these as errors and not respecting the warning, but switching them to suggestions works, so I am going to submit a PR for this.

[jnm2]

Thanks Rob!